[jira] [Closed] (HBASE-22090) The HFileBlock#CacheableDeserializer should pass ByteBuffAllocator to the newly created HFileBlock

["Andrew Kyle Purtell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-22090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kyle Purtell closed HBASE-22090.
---------------------------------------

> The HFileBlock#CacheableDeserializer should pass ByteBuffAllocator to the newly created HFileBlock
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-22090
>                 URL: https://issues.apache.org/jira/browse/HBASE-22090
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.3.0
>
>         Attachments: HBASE-22090.HBASE-21879.v01.patch, HBASE-22090.HBASE-21879.v02.patch, HBASE-22090.HBASE-21879.v03.patch
>
>
> In HBASE-22005, we have the following TODO in HFileBlock#CacheableDeserializer:
> {code}
>   public static final class BlockDeserializer implements CacheableDeserializer<Cacheable> {
>     private BlockDeserializer() {
>     }
>     @Override
>     public HFileBlock deserialize(ByteBuff buf, boolean reuse, MemoryType memType)
>         throws IOException {
>        // ....
>       // TODO make the newly created HFileBlock use the off-heap allocator, Need change the
>       // deserializer or change the deserialize interface.
>       return new HFileBlock(newByteBuff, usesChecksum, memType, offset, nextBlockOnDiskSize, null,
>           ByteBuffAllocator.HEAP);
>     }
> {code}
> Should use the global ByteBuffAllocator here rather than HEAP allocator, as the TODO said, we need to adjust the interface of deserializer. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)