You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Thorsten Scherler (JIRA)" <ji...@apache.org> on 2008/08/25 12:07:44 UTC

[jira] Created: (COCOON-2241) The commandline is not working since cocoon-1985

The commandline is not working since cocoon-1985
------------------------------------------------

                 Key: COCOON-2241
                 URL: https://issues.apache.org/jira/browse/COCOON-2241
             Project: Cocoon
          Issue Type: Bug
          Components: * Cocoon Core
    Affects Versions: 2.1.12-dev (Current SVN)
            Reporter: Thorsten Scherler
             Fix For: 2.1.12-dev (Current SVN)


Updating forrest to use cocoon-2.1.x, I found a problem in the
AbstractCachingProcessingPipeline.

I am not sure whether someone is using the cocoon cli ATM. Forrest is
based around this component. 

https://issues.apache.org/jira/browse/FOR-955?focusedCommentId=12624340#action_12624340

I found that in
org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline line 245 
Object lock =
env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT); 
the lock is null which causes the NPE in the end.

The problem is that the cli environment does not store the requested object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (COCOON-2241) The commandline is not working since cocoon-1985

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Tue, 2008-08-26 at 00:45 -0700, Thorsten Scherler (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/COCOON-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Thorsten Scherler updated COCOON-2241:
> --------------------------------------
> 
>     Attachment: COCOON-2241.txt
> 
> Fixing small error that intruded the patch

Is it ok that I apply the patch and leave the issue open for later
review?

I mean the CLI is broken ATM and this patch fixes this. The fix may not
be 100% concurrent proof but that we can fix later on.

WDYT?

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


[jira] Updated: (COCOON-2241) The commandline is not working since cocoon-1985

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thorsten Scherler updated COCOON-2241:
--------------------------------------

    Attachment: COCOON-2241.txt

Fixing small error that intruded the patch

> The commandline is not working since cocoon-1985
> ------------------------------------------------
>
>                 Key: COCOON-2241
>                 URL: https://issues.apache.org/jira/browse/COCOON-2241
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Thorsten Scherler
>             Fix For: 2.1.12-dev (Current SVN)
>
>         Attachments: COCOON-2241.txt, COCOON-2241.txt, COCOON-2241.txt
>
>
> Updating forrest to use cocoon-2.1.x, I found a problem in the
> AbstractCachingProcessingPipeline.
> I am not sure whether someone is using the cocoon cli ATM. Forrest is
> based around this component. 
> https://issues.apache.org/jira/browse/FOR-955?focusedCommentId=12624340#action_12624340
> I found that in
> org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline line 245 
> Object lock =
> env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT); 
> the lock is null which causes the NPE in the end.
> The problem is that the cli environment does not store the requested object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-2241) The commandline is not working since cocoon-1985

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625313#action_12625313 ] 

Thorsten Scherler commented on COCOON-2241:
-------------------------------------------

"env.getObjectModel()"= HashMap<K,V> (id=271)
DEFAULT_INITIAL_CAPACITY= 16
DEFAULT_LOAD_FACTOR= 0.75
MAXIMUM_CAPACITY= 1073741824
NULL_KEY= Object (id=301)
serialVersionUID= 362498820763181265
useNewHash= false
entrySet= HashMap$EntrySet (id=295)
keySet= null

HashMap values:
[null, response=org.apache.cocoon.environment.wrapper.ResponseWrapper@fd4662, link-collection=[], request=org.apache.cocoon.environment.wrapper.RequestWrapper@6dddcf, null, null, null, null, context=org.apache.cocoon.environment.commandline.CommandLineContext@14ba9a2, null, null, source-resolver=org.apache.cocoon.environment.commandline.FileSavingEnvironment@725967, org.apache.cocoon.components.CocoonComponentManager=org.apache.cocoon.components.EnvironmentDescription@d2efa1, null, null, null] 

> The commandline is not working since cocoon-1985
> ------------------------------------------------
>
>                 Key: COCOON-2241
>                 URL: https://issues.apache.org/jira/browse/COCOON-2241
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Thorsten Scherler
>             Fix For: 2.1.12-dev (Current SVN)
>
>         Attachments: COCOON-2241.txt
>
>
> Updating forrest to use cocoon-2.1.x, I found a problem in the
> AbstractCachingProcessingPipeline.
> I am not sure whether someone is using the cocoon cli ATM. Forrest is
> based around this component. 
> https://issues.apache.org/jira/browse/FOR-955?focusedCommentId=12624340#action_12624340
> I found that in
> org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline line 245 
> Object lock =
> env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT); 
> the lock is null which causes the NPE in the end.
> The problem is that the cli environment does not store the requested object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2241) The commandline is not working since cocoon-1985

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thorsten Scherler updated COCOON-2241:
--------------------------------------

    Attachment: COCOON-2241.txt

Proposed solution

> The commandline is not working since cocoon-1985
> ------------------------------------------------
>
>                 Key: COCOON-2241
>                 URL: https://issues.apache.org/jira/browse/COCOON-2241
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Thorsten Scherler
>             Fix For: 2.1.12-dev (Current SVN)
>
>         Attachments: COCOON-2241.txt
>
>
> Updating forrest to use cocoon-2.1.x, I found a problem in the
> AbstractCachingProcessingPipeline.
> I am not sure whether someone is using the cocoon cli ATM. Forrest is
> based around this component. 
> https://issues.apache.org/jira/browse/FOR-955?focusedCommentId=12624340#action_12624340
> I found that in
> org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline line 245 
> Object lock =
> env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT); 
> the lock is null which causes the NPE in the end.
> The problem is that the cli environment does not store the requested object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (COCOON-2241) The commandline is not working since cocoon-1985

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thorsten Scherler closed COCOON-2241.
-------------------------------------

    Resolution: Fixed

> The commandline is not working since cocoon-1985
> ------------------------------------------------
>
>                 Key: COCOON-2241
>                 URL: https://issues.apache.org/jira/browse/COCOON-2241
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Thorsten Scherler
>             Fix For: 2.1.12-dev (Current SVN)
>
>         Attachments: COCOON-2241.txt, COCOON-2241.txt, COCOON-2241.txt
>
>
> Updating forrest to use cocoon-2.1.x, I found a problem in the
> AbstractCachingProcessingPipeline.
> I am not sure whether someone is using the cocoon cli ATM. Forrest is
> based around this component. 
> https://issues.apache.org/jira/browse/FOR-955?focusedCommentId=12624340#action_12624340
> I found that in
> org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline line 245 
> Object lock =
> env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT); 
> the lock is null which causes the NPE in the end.
> The problem is that the cli environment does not store the requested object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-2241) The commandline is not working since cocoon-1985

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627631#action_12627631 ] 

Thorsten Scherler commented on COCOON-2241:
-------------------------------------------

Committed revision 691199

Slight modification:
changed one line to be:

   this.objectModel.put(CLI_REQUEST_ID, new String(uri));

> The commandline is not working since cocoon-1985
> ------------------------------------------------
>
>                 Key: COCOON-2241
>                 URL: https://issues.apache.org/jira/browse/COCOON-2241
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Thorsten Scherler
>             Fix For: 2.1.12-dev (Current SVN)
>
>         Attachments: COCOON-2241.txt, COCOON-2241.txt, COCOON-2241.txt
>
>
> Updating forrest to use cocoon-2.1.x, I found a problem in the
> AbstractCachingProcessingPipeline.
> I am not sure whether someone is using the cocoon cli ATM. Forrest is
> based around this component. 
> https://issues.apache.org/jira/browse/FOR-955?focusedCommentId=12624340#action_12624340
> I found that in
> org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline line 245 
> Object lock =
> env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT); 
> the lock is null which causes the NPE in the end.
> The problem is that the cli environment does not store the requested object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2241) The commandline is not working since cocoon-1985

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thorsten Scherler updated COCOON-2241:
--------------------------------------

    Attachment: COCOON-2241.txt

New version of the patch.

Moving common code from Cli env inplementation to the Abstract class and creating a new object (simple uri string) for the lock.

> The commandline is not working since cocoon-1985
> ------------------------------------------------
>
>                 Key: COCOON-2241
>                 URL: https://issues.apache.org/jira/browse/COCOON-2241
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Thorsten Scherler
>             Fix For: 2.1.12-dev (Current SVN)
>
>         Attachments: COCOON-2241.txt, COCOON-2241.txt
>
>
> Updating forrest to use cocoon-2.1.x, I found a problem in the
> AbstractCachingProcessingPipeline.
> I am not sure whether someone is using the cocoon cli ATM. Forrest is
> based around this component. 
> https://issues.apache.org/jira/browse/FOR-955?focusedCommentId=12624340#action_12624340
> I found that in
> org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline line 245 
> Object lock =
> env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT); 
> the lock is null which causes the NPE in the end.
> The problem is that the cli environment does not store the requested object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-2241) The commandline is not working since cocoon-1985

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625310#action_12625310 ] 

Thorsten Scherler commented on COCOON-2241:
-------------------------------------------

mail thread around this issue:
http://marc.info/?t=121932134400001&r=1&w=2 

> The commandline is not working since cocoon-1985
> ------------------------------------------------
>
>                 Key: COCOON-2241
>                 URL: https://issues.apache.org/jira/browse/COCOON-2241
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Thorsten Scherler
>             Fix For: 2.1.12-dev (Current SVN)
>
>
> Updating forrest to use cocoon-2.1.x, I found a problem in the
> AbstractCachingProcessingPipeline.
> I am not sure whether someone is using the cocoon cli ATM. Forrest is
> based around this component. 
> https://issues.apache.org/jira/browse/FOR-955?focusedCommentId=12624340#action_12624340
> I found that in
> org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline line 245 
> Object lock =
> env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT); 
> the lock is null which causes the NPE in the end.
> The problem is that the cli environment does not store the requested object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.