You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/19 10:55:59 UTC
[GitHub] [ignite-3] AMashenkov opened a new pull request #133: IGNITE-14732: Introduce SortOrder enum for indexed column.
AMashenkov opened a new pull request #133:
URL: https://github.com/apache/ignite-3/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #133: IGNITE-14732: Introduce SortOrder enum for indexed column.
Posted by GitBox <gi...@apache.org>.
AMashenkov merged pull request #133:
URL: https://github.com/apache/ignite-3/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a change in pull request #133: IGNITE-14732: Introduce SortOrder enum for indexed column.
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #133:
URL: https://github.com/apache/ignite-3/pull/133#discussion_r639569455
##########
File path: modules/api/src/main/java/org/apache/ignite/schema/SortedIndexColumn.java
##########
@@ -22,7 +22,7 @@
*/
public interface SortedIndexColumn extends IndexColumn {
Review comment:
do we have any plans to support null ordering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #133: IGNITE-14732: Introduce SortOrder enum for indexed column.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #133:
URL: https://github.com/apache/ignite-3/pull/133#discussion_r639575547
##########
File path: modules/api/src/main/java/org/apache/ignite/schema/SortedIndexColumn.java
##########
@@ -22,7 +22,7 @@
*/
public interface SortedIndexColumn extends IndexColumn {
Review comment:
Yep, I've missed this. Let's create a ticket for this.
I'm not sure it would be the only good idea to add options like ASC_NULL_FIRST to SortOrder enum, as long as non-nullable columns are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a change in pull request #133: IGNITE-14732: Introduce SortOrder enum for indexed column.
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #133:
URL: https://github.com/apache/ignite-3/pull/133#discussion_r639569455
##########
File path: modules/api/src/main/java/org/apache/ignite/schema/SortedIndexColumn.java
##########
@@ -22,7 +22,7 @@
*/
public interface SortedIndexColumn extends IndexColumn {
Review comment:
do we have any plans to support nulls ordering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #133: IGNITE-14732: Introduce SortOrder enum for indexed column.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #133:
URL: https://github.com/apache/ignite-3/pull/133#discussion_r639575547
##########
File path: modules/api/src/main/java/org/apache/ignite/schema/SortedIndexColumn.java
##########
@@ -22,7 +22,7 @@
*/
public interface SortedIndexColumn extends IndexColumn {
Review comment:
Yep, I've missed this. Let's create a ticket for this.
I'm not sure it would be a good idea to add options like ASC_NULL_FIRST to SortOrder enum, as long as non-nullable columns are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org