You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/28 07:50:22 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #4332: feat: add real_ip_recursive to nginx.conf

spacewander commented on a change in pull request #4332:
URL: https://github.com/apache/apisix/pull/4332#discussion_r641343710



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -229,6 +229,10 @@ http {
     real_ip_header {* http.real_ip_header *};
     {% end %}
 
+    {% if http.real_ip_recursive then %}
+    real_ip_recursive {* http.real_ip_recursive *};

Review comment:
       Need to add a test like: https://github.com/apache/apisix/blob/9a40fd7cb497974f9d7bd75f128eed5dd238cdc6/t/cli/test_main.sh#L382-L399




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org