You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by ro...@animalcules.com on 2002/12/08 19:10:55 UTC
Issue 1027
Patch for issue 1027
Posted by ro...@animalcules.com.
> how about putting together a patch and a log message for it? i'll be
> happy to review and commit it for you.
* subversion/clients/cmdline/util.c
(svn_cl__get_log_message):
Initialize block variable msg2 to NULL.
Index: subversion/clients/cmdline/util.c
===================================================================
--- subversion/clients/cmdline/util.c (revision 4054)
+++ subversion/clients/cmdline/util.c (working copy)
@@ -406,7 +406,7 @@
int i;
svn_stringbuf_t *tmp_message = svn_stringbuf_create (default_msg, pool);
svn_error_t *err = NULL;
- const char *msg2; /* ### shim for svn_cl__edit_externally */
+ const char *msg2 = NULL; /* ### shim for svn_cl__edit_externally */
for (i = 0; i < commit_items->nelts; i++)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Issue 1027
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Sunday, December 8, 2002, at 02:10 PM, rotering@animalcules.com
wrote:
>> From the description of issue 1027:
>
> file: subversion/clients/cmdline/util.c
> line: 447
> function: svn_cl__get_log_message
>
> msg2 is never set to NULL and if svn_cl__get_log_message fails
> msg2 is
> not effected. A more appropriate check would be if(!err)
>
> Initializing msg2 to NULL would fix this problem as well as a similar
> one on line 476.
>
> Just to clarify the effect of this bug:
>
> If svn_cl__edit_externally() on line 445 fails and msg2 happens to be
> nonzero (because it's uninitialized) the call to strlen on line 455
> raises SIGSEGV.
it sure looks like a bug to me.
how about putting together a patch and a log message for it? i'll be
happy to review and commit it for you.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org