You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/19 04:31:11 UTC
Re: Review Request 65995: Ensured wanted offers in
`RetryOperationStatusUpdate*` SLRP tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65995/
-----------------------------------------------------------
(Updated June 19, 2018, 4:31 a.m.)
Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and Jie Yu.
Summary (updated)
-----------------
Ensured wanted offers in `RetryOperationStatusUpdate*` SLRP tests.
Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825
Repository: mesos
Description (updated)
-------
The two SLRP tests assume that SLRP will send out a RAW resource before
the test framework registers, and thus the framework would receive the
RAW resource in its first offer, but this assumption is not guaranteed.
This patch ensures the assumption by settling the clock in advance.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/65995/diff/8/
Changes: https://reviews.apache.org/r/65995/diff/7-8/
Testing
-------
sudo make check
Ran the two tests in repitition.
Thanks,
Chun-Hung Hsiao
Re: Review Request 65995: Declined unwanted offers in
`RetryOperationStatusUpdate*` SLRP tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65995/
-----------------------------------------------------------
(Updated June 19, 2018, 9:16 p.m.)
Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and Jie Yu.
Changes
-------
Reverted to revision 7 since revision 8 is flaky: `Clock::settle()` won't wait for `UPDATE_STATE` calls in HTTP pipes.
Summary (updated)
-----------------
Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.
Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825
Repository: mesos
Description (updated)
-------
The two SLRP tests assume that SLRP will send out a RAW resource in its
first `UPDATE_STATE` message, and expect that the test framework would
receive an offer containing the RAW resource in its first offer. However
this behavior is not guaranteed and should not be relied on. This patch
makes the tests decline unwanted offers by default so they no longer
rely on SLRP's internal behavior.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/65995/diff/9/
Changes: https://reviews.apache.org/r/65995/diff/8-9/
Testing
-------
sudo make check
Ran the two tests in repitition.
Thanks,
Chun-Hung Hsiao