You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/16 02:25:41 UTC

[jira] [Commented] (ROCKETMQ-144) Aggregate distribution specific files to a new module

    [ https://issues.apache.org/jira/browse/ROCKETMQ-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927350#comment-15927350 ] 

ASF GitHub Bot commented on ROCKETMQ-144:
-----------------------------------------

GitHub user lizhanhui opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/79

    [ROCKETMQ-144]Aggregate packaging specific files to a new sub-module

    When running maven-assembly-plugin, it constantly warns and suggests to use a separate sub-module to aggregate packaging files, which are scattered in the parent projects. Usage of this is exemplified http://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-144

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit 6d7bf416e53d5bd4ece4845ee3f9e634aeec8ef1
Author: Li Zhanhui <li...@apache.org>
Date:   2017-03-16T02:21:33Z

    Aggregate packaging specific files to a new sub-module

----


> Aggregate distribution specific files to a new module
> -----------------------------------------------------
>
>                 Key: ROCKETMQ-144
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-144
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>
> When running maven-assembly-plugin, it constantly warns and suggests to use a separate sub-module to aggregate packaging files, which are scattered in the parent projects. Usage of this is exemplified http://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)