You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by jklukas <gi...@git.apache.org> on 2016/05/12 16:18:06 UTC

[GitHub] kafka pull request: MINOR: Call Metrics.close() in KafkaStreams

GitHub user jklukas opened a pull request:

    https://github.com/apache/kafka/pull/1379

    MINOR: Call Metrics.close() in KafkaStreams

    Initially proposed by @ijuma in https://github.com/apache/kafka/pull/1362#issuecomment-218293662
    
    @mjsax commented:
    
    > StreamThread.close() should be extended to call metrics.close() (the class need a private member to reference the Metrics object, too)
    
    The `Metrics` instance is created in the `KafkaStreams` constructor and shared between all threads, so closing it within the threads doesn't seem like the right approach. This PR calls `Metrics.close()` in `KafkaStreams.close()` instead.
    
    cc @guozhangwang 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jklukas/kafka close-streams-metrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1379
    
----
commit 1066244aafa165e2ac22c9f43d44b754aca3c6d4
Author: Jeff Klukas <je...@klukas.net>
Date:   2016-05-10T20:51:46Z

    Call Metrics.close() in KafkaStreams

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: MINOR: Fix bugs in KafkaStreams.close()

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1379


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---