You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Aihua Xu <ax...@cloudera.com> on 2016/02/04 17:27:19 UTC

Review Request 43192: HIVE-9534: incorrect result set for query that projects a windowed aggregate

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43192/
-----------------------------------------------------------

Review request for hive, Chaoyu Tang, Szehon Ho, Xuefu Zhang, and Yongzhi Chen.


Repository: hive-git


Description
-------

HIVE-9534: incorrect result set for query that projects a windowed aggregate


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/CanAggregateDistinct.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlCountAggFunction.java 58191e5e6e3d999f176884c6b71e6a781d9ba3ff 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlSumAggFunction.java 498cd0ecaa52afa890e22a4f35754ad15dd4664d 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 19aa414419bc0d3525ce3d05a59e2a17724b495e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java cd2449fdc2d1cdd595c764e9b3da4c0811b2e763 
  ql/src/test/queries/clientpositive/windowing_distinct.q 9f6ddfd0934bc695f69576b5a7523fe7d49be4e6 
  ql/src/test/results/clientpositive/windowing_distinct.q.out 0858f0f38c977c77fd0fc9919094f48ebf3a09f3 

Diff: https://reviews.apache.org/r/43192/diff/


Testing
-------

Similar to sum(distinct) and count(distinct) supported, add avg(distinct) in this patch.


Thanks,

Aihua Xu


Re: Review Request 43192: HIVE-9534: incorrect result set for query that projects a windowed aggregate

Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43192/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 4:31 p.m.)


Review request for hive, Chaoyu Tang, Szehon Ho, Xuefu Zhang, and Yongzhi Chen.


Repository: hive-git


Description
-------

HIVE-9534: incorrect result set for query that projects a windowed aggregate


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/CanAggregateDistinct.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlCountAggFunction.java 58191e5 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlSumAggFunction.java 498cd0e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 19aa414 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java cd2449f 
  ql/src/test/queries/clientpositive/windowing_distinct.q 9f6ddfd 
  ql/src/test/results/clientpositive/windowing_distinct.q.out 0858f0f 

Diff: https://reviews.apache.org/r/43192/diff/


Testing
-------

Similar to sum(distinct) and count(distinct) supported, add avg(distinct) in this patch.


Thanks,

Aihua Xu