You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Alexey Petrenko <al...@gmail.com> on 2007/09/04 12:10:38 UTC
Re: svn commit: r572598 - /harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
I've uncommented stack trace printing in EventDispatchThread. This
commented stack trace printing just hides the exceptions and awt/swing
application most likely hangs.
However you should not have any output if everything goes ok.
I hope nobody objects :)
SY, Alexey
2007/9/4, apetrenko@apache.org <ap...@apache.org>:
> Author: apetrenko
> Date: Tue Sep 4 02:59:59 2007
> New Revision: 572598
>
> URL: http://svn.apache.org/viewvc?rev=572598&view=rev
> Log:
> Stack trace printing is uncommented in EventDispatchThread. This commented stack trace printing just hides the exceptions and awt/swing application most likely hangs.
>
> Modified:
> harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
>
> Modified: harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java?rev=572598&r1=572597&r2=572598&view=diff
> ==============================================================================
> --- harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java (original)
> +++ harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java Tue Sep 4 02:59:59 2007
> @@ -86,7 +86,7 @@
> }
> } catch (Throwable t) {
> // TODO: Exception handler should be implemented
> - // t.printStackTrace();
> + t.printStackTrace();
> }
> }
> }
>
>
>
Re: svn commit: r572598 - /harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
Posted by Alexey Petrenko <al...@gmail.com>.
Tim has commented out this test.
Yes, let's reopen HARMONY-2116.
SY, Alexey
2007/9/17, Alexei Zakharov <al...@gmail.com>:
> Alexey,
>
> This your commit (r572598) causes the regression test for HARMONY-2116
> to fail. And this is not a big surprise for me since the patch for
> this JIRA looks like a reverted version of your commit:
>
> EventDispatchThread.patch:
> ---
> Index: src/main/java/common/java/awt/EventDispatchThread.java
> ===================================================================
> --- src/main/java/common/java/awt/EventDispatchThread.java (revision 501394)
> +++ src/main/java/common/java/awt/EventDispatchThread.java (working copy)
> @@ -85,7 +85,8 @@
> }
> }
> } catch (Throwable t) {
> - t.printStackTrace();
> + // TODO: Exception handler should be implemented
> + // t.printStackTrace();
> }
> }
> }
> ---
>
> I understand that if somebody works on enabling of Swing/AWT
> applications then it can be extremely useful to see the stack traces.
> This way, I suggest to reopen HARMONY-2116 and move this test to
> exclude list for now until we are stable enough. Or we need to
> implement a better (configurable?) way to report errors&exceptions in
> AWT code.
>
> Regards,
> Alexei
>
> 2007/9/4, Alexey Petrenko <al...@gmail.com>:
> > I've uncommented stack trace printing in EventDispatchThread. This
> > commented stack trace printing just hides the exceptions and awt/swing
> > application most likely hangs.
> > However you should not have any output if everything goes ok.
> >
> > I hope nobody objects :)
> >
> > SY, Alexey
> >
> > 2007/9/4, apetrenko@apache.org <ap...@apache.org>:
> > > Author: apetrenko
> > > Date: Tue Sep 4 02:59:59 2007
> > > New Revision: 572598
> > >
> > > URL: http://svn.apache.org/viewvc?rev=572598&view=rev
> > > Log:
> > > Stack trace printing is uncommented in EventDispatchThread. This commented stack trace printing just hides the exceptions and awt/swing application most likely hangs.
> > >
> > > Modified:
> > > harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
> > >
> > > Modified: harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
> > > URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java?rev=572598&r1=572597&r2=572598&view=diff
> > > ==============================================================================
> > > --- harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java (original)
> > > +++ harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java Tue Sep 4 02:59:59 2007
> > > @@ -86,7 +86,7 @@
> > > }
> > > } catch (Throwable t) {
> > > // TODO: Exception handler should be implemented
> > > - // t.printStackTrace();
> > > + t.printStackTrace();
> > > }
> > > }
> > > }
>
Re: svn commit: r572598 - /harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
Posted by Alexei Zakharov <al...@gmail.com>.
Alexey,
This your commit (r572598) causes the regression test for HARMONY-2116
to fail. And this is not a big surprise for me since the patch for
this JIRA looks like a reverted version of your commit:
EventDispatchThread.patch:
---
Index: src/main/java/common/java/awt/EventDispatchThread.java
===================================================================
--- src/main/java/common/java/awt/EventDispatchThread.java (revision 501394)
+++ src/main/java/common/java/awt/EventDispatchThread.java (working copy)
@@ -85,7 +85,8 @@
}
}
} catch (Throwable t) {
- t.printStackTrace();
+ // TODO: Exception handler should be implemented
+ // t.printStackTrace();
}
}
}
---
I understand that if somebody works on enabling of Swing/AWT
applications then it can be extremely useful to see the stack traces.
This way, I suggest to reopen HARMONY-2116 and move this test to
exclude list for now until we are stable enough. Or we need to
implement a better (configurable?) way to report errors&exceptions in
AWT code.
Regards,
Alexei
2007/9/4, Alexey Petrenko <al...@gmail.com>:
> I've uncommented stack trace printing in EventDispatchThread. This
> commented stack trace printing just hides the exceptions and awt/swing
> application most likely hangs.
> However you should not have any output if everything goes ok.
>
> I hope nobody objects :)
>
> SY, Alexey
>
> 2007/9/4, apetrenko@apache.org <ap...@apache.org>:
> > Author: apetrenko
> > Date: Tue Sep 4 02:59:59 2007
> > New Revision: 572598
> >
> > URL: http://svn.apache.org/viewvc?rev=572598&view=rev
> > Log:
> > Stack trace printing is uncommented in EventDispatchThread. This commented stack trace printing just hides the exceptions and awt/swing application most likely hangs.
> >
> > Modified:
> > harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
> >
> > Modified: harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java
> > URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java?rev=572598&r1=572597&r2=572598&view=diff
> > ==============================================================================
> > --- harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java (original)
> > +++ harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt/EventDispatchThread.java Tue Sep 4 02:59:59 2007
> > @@ -86,7 +86,7 @@
> > }
> > } catch (Throwable t) {
> > // TODO: Exception handler should be implemented
> > - // t.printStackTrace();
> > + t.printStackTrace();
> > }
> > }
> > }