You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2016/12/22 14:51:51 UTC
Review Request 54979: Typo in the PostgreSQL database name for druid
service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Slim Bouguerra, and Sebastian Toader.
Bugs: AMBARI-19278
https://issues.apache.org/jira/browse/AMBARI-19278
Repository: ambari
Description
-------
The stack_advisor script for druid uses 'postgres' as storage type. The documentation of druid says it should be postgresql
http://druid.io/docs/latest/development/extensions-core/postgresql.html
Diffs
-----
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
Diff: https://reviews.apache.org/r/54979/diff/
Testing
-------
Manually tested by importing a druid blueprint:
1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained an error 'NoneType' object has no attribute 'format'
2. after applying the patch the error disappeared
Still waiting for the mvn test results
Thanks,
Attila Magyar
Re: Review Request 54979: Typo in the PostgreSQL database name for
druid service
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/
-----------------------------------------------------------
(Updated Dec. 22, 2016, 3:16 p.m.)
Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Slim Bouguerra, and Sebastian Toader.
Changes
-------
added branches: trunk, 2.5
Bugs: AMBARI-19278
https://issues.apache.org/jira/browse/AMBARI-19278
Repository: ambari
Description
-------
The stack_advisor script for druid uses 'postgres' as storage type. The documentation of druid says it should be postgresql
http://druid.io/docs/latest/development/extensions-core/postgresql.html
Diffs
-----
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
Diff: https://reviews.apache.org/r/54979/diff/
Testing
-------
Manually tested by importing a druid blueprint:
1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained an error 'NoneType' object has no attribute 'format'
2. after applying the patch the error disappeared
Still waiting for the mvn test results
Thanks,
Attila Magyar
Re: Review Request 54979: Typo in the PostgreSQL database name for
druid service
Posted by Attila Magyar <am...@hortonworks.com>.
> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote:
> > also i have sent the patch to Apache JIRA
> > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.
>
> Attila Magyar wrote:
> I think it was not applied because it was created from the ambari-server directory instead of the project root.
>
> Slim Bouguerra wrote:
> @Attila Magyar your patch is exactly the same to mine not sure what you mean by created inside an ambari-server ?
@Slim Bouguerra the content of the 2 patches are the same but something is wrong with the format of your patch. If you download the 2 patch files and compare it you'll see that one of them uses paths like:
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
and the other uses:
a/ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
This was the reason it didn't apply.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
-----------------------------------------------------------
On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 2:51 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Slim Bouguerra, and Sebastian Toader.
>
>
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The stack_advisor script for druid uses 'postgres' as storage type. The documentation of druid says it should be postgresql
>
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
>
> Diff: https://reviews.apache.org/r/54979/diff/
>
>
> Testing
> -------
>
> Manually tested by importing a druid blueprint:
> 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained an error 'NoneType' object has no attribute 'format'
> 2. after applying the patch the error disappeared
>
>
> Still waiting for the mvn test results
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 54979: Typo in the PostgreSQL database name for
druid service
Posted by Slim Bouguerra <sb...@hortonworks.com>.
> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote:
> > also i have sent the patch to Apache JIRA
> > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.
>
> Attila Magyar wrote:
> I think it was not applied because it was created from the ambari-server directory instead of the project root.
@Attila Magyar your patch is exactly the same to mine not sure what you mean by created inside an ambari-server ?
- Slim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
-----------------------------------------------------------
On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 2:51 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Slim Bouguerra, and Sebastian Toader.
>
>
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The stack_advisor script for druid uses 'postgres' as storage type. The documentation of druid says it should be postgresql
>
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
>
> Diff: https://reviews.apache.org/r/54979/diff/
>
>
> Testing
> -------
>
> Manually tested by importing a druid blueprint:
> 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained an error 'NoneType' object has no attribute 'format'
> 2. after applying the patch the error disappeared
>
>
> Still waiting for the mvn test results
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 54979: Typo in the PostgreSQL database name for
druid service
Posted by Slim Bouguerra <sb...@hortonworks.com>.
> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote:
> > also i have sent the patch to Apache JIRA
> > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.
>
> Attila Magyar wrote:
> I think it was not applied because it was created from the ambari-server directory instead of the project root.
>
> Slim Bouguerra wrote:
> @Attila Magyar your patch is exactly the same to mine not sure what you mean by created inside an ambari-server ?
>
> Attila Magyar wrote:
> @Slim Bouguerra the content of the 2 patches are the same but something is wrong with the format of your patch. If you download the 2 patch files and compare it you'll see that one of them uses paths like:
>
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
>
> and the other uses:
>
> a/ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
>
> This was the reason it didn't apply.
Well that `a` is a git detail it is removed when you generate a diff with the option --no-prefix thus both patch are generated against the same git branch....
- Slim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
-----------------------------------------------------------
On Dec. 22, 2016, 3:16 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 3:16 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Slim Bouguerra, and Sebastian Toader.
>
>
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The stack_advisor script for druid uses 'postgres' as storage type. The documentation of druid says it should be postgresql
>
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
>
> Diff: https://reviews.apache.org/r/54979/diff/
>
>
> Testing
> -------
>
> Manually tested by importing a druid blueprint:
> 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained an error 'NoneType' object has no attribute 'format'
> 2. after applying the patch the error disappeared
>
>
> Still waiting for the mvn test results
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 54979: Typo in the PostgreSQL database name for
druid service
Posted by Attila Magyar <am...@hortonworks.com>.
> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote:
> > also i have sent the patch to Apache JIRA
> > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.
I think it was not applied because it was created from the ambari-server directory instead of the project root.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
-----------------------------------------------------------
On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 2:51 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Slim Bouguerra, and Sebastian Toader.
>
>
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The stack_advisor script for druid uses 'postgres' as storage type. The documentation of druid says it should be postgresql
>
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
>
> Diff: https://reviews.apache.org/r/54979/diff/
>
>
> Testing
> -------
>
> Manually tested by importing a druid blueprint:
> 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained an error 'NoneType' object has no attribute 'format'
> 2. after applying the patch the error disappeared
>
>
> Still waiting for the mvn test results
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 54979: Typo in the PostgreSQL database name for
druid service
Posted by Slim Bouguerra <sb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
-----------------------------------------------------------
also i have sent the patch to Apache JIRA
https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.
- Slim Bouguerra
On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 2:51 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Slim Bouguerra, and Sebastian Toader.
>
>
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The stack_advisor script for druid uses 'postgres' as storage type. The documentation of druid says it should be postgresql
>
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
>
> Diff: https://reviews.apache.org/r/54979/diff/
>
>
> Testing
> -------
>
> Manually tested by importing a druid blueprint:
> 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained an error 'NoneType' object has no attribute 'format'
> 2. after applying the patch the error disappeared
>
>
> Still waiting for the mvn test results
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 54979: Typo in the PostgreSQL database name for
druid service
Posted by Slim Bouguerra <sb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159960
-----------------------------------------------------------
i have sennt a PR alreadsy
https://reviews.apache.org/r/54966/
can you please review it ?
- Slim Bouguerra
On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 2:51 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Slim Bouguerra, and Sebastian Toader.
>
>
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The stack_advisor script for druid uses 'postgres' as storage type. The documentation of druid says it should be postgresql
>
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
>
> Diff: https://reviews.apache.org/r/54979/diff/
>
>
> Testing
> -------
>
> Manually tested by importing a druid blueprint:
> 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained an error 'NoneType' object has no attribute 'format'
> 2. after applying the patch the error disappeared
>
>
> Still waiting for the mvn test results
>
>
> Thanks,
>
> Attila Magyar
>
>