You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ch...@apache.org on 2017/12/18 16:45:56 UTC
hbase git commit: HBASE-19531 Remove needless volatile declaration
Repository: hbase
Updated Branches:
refs/heads/branch-2 07d20b2d1 -> 589571942
HBASE-19531 Remove needless volatile declaration
Signed-off-by: Chia-Ping Tsai <ch...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/58957194
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/58957194
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/58957194
Branch: refs/heads/branch-2
Commit: 589571942011bc793b3898654b120a9a1543e305
Parents: 07d20b2
Author: Yun Chi-Shih <le...@gmail.com>
Authored: Mon Dec 18 23:24:58 2017 +0800
Committer: Chia-Ping Tsai <ch...@gmail.com>
Committed: Tue Dec 19 00:40:37 2017 +0800
----------------------------------------------------------------------
.../java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java | 2 +-
.../src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java | 2 +-
.../src/main/java/org/apache/hadoop/hbase/ZKNamespaceManager.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/58957194/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
index c772b78..b91038d 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
@@ -73,7 +73,7 @@ public class BufferedMutatorImpl implements BufferedMutator {
* The {@link ConcurrentLinkedQueue#size()} is NOT a constant-time operation.
*/
private final AtomicInteger undealtMutationCount = new AtomicInteger(0);
- private volatile long writeBufferSize;
+ private final long writeBufferSize;
private final int maxKeyValueSize;
private final ExecutorService pool;
private final AtomicInteger rpcTimeout;
http://git-wip-us.apache.org/repos/asf/hbase/blob/58957194/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
index 2ea7c74..ef054b6 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
@@ -227,7 +227,7 @@ public class HBaseAdmin implements Admin {
private ClusterConnection connection;
- private volatile Configuration conf;
+ private final Configuration conf;
private final long pause;
private final int numRetries;
private final int syncWaitTimeout;
http://git-wip-us.apache.org/repos/asf/hbase/blob/58957194/hbase-server/src/main/java/org/apache/hadoop/hbase/ZKNamespaceManager.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ZKNamespaceManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ZKNamespaceManager.java
index de21ce0..9e228ad 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ZKNamespaceManager.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ZKNamespaceManager.java
@@ -51,7 +51,7 @@ import java.util.concurrent.ConcurrentSkipListMap;
public class ZKNamespaceManager extends ZKListener {
private static final Log LOG = LogFactory.getLog(ZKNamespaceManager.class);
private final String nsZNode;
- private volatile NavigableMap<String,NamespaceDescriptor> cache;
+ private final NavigableMap<String,NamespaceDescriptor> cache;
public ZKNamespaceManager(ZKWatcher zkw) throws IOException {
super(zkw);