You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2021/01/07 15:07:39 UTC
[hbase] branch HBASE-25476 created (now 306a978)
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a change to branch HBASE-25476
in repository https://gitbox.apache.org/repos/asf/hbase.git.
at 306a978 HBASE-25476 Enable error prone check in pre commit
This branch includes the following new commits:
new 306a978 HBASE-25476 Enable error prone check in pre commit
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[hbase] 01/01: HBASE-25476 Enable error prone check in pre commit
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch HBASE-25476
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 306a9781f0722b12cd30d8e19d49fd4aa0aba80a
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Thu Jan 7 23:06:41 2021 +0800
HBASE-25476 Enable error prone check in pre commit
---
dev-support/Jenkinsfile_GitHub | 4 +++-
dev-support/hbase-personality.sh | 2 +-
dev-support/jenkins_precommit_github_yetus.sh | 5 ++++-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/dev-support/Jenkinsfile_GitHub b/dev-support/Jenkinsfile_GitHub
index d253867..9df6c8c 100644
--- a/dev-support/Jenkinsfile_GitHub
+++ b/dev-support/Jenkinsfile_GitHub
@@ -38,7 +38,7 @@ pipeline {
YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins_precommit_github_yetus.sh"
// Branch or tag name. Yetus release tags are 'rel/X.Y.Z'
YETUS_VERSION = 'rel/0.12.0'
- GENERAL_CHECK_PLUGINS = 'all,-compile,-javac,-javadoc,-jira,-shadedjars,-unit'
+ GENERAL_CHECK_PLUGINS = 'all,-javadoc,-jira,-shadedjars,-unit'
JDK_SPECIFIC_PLUGINS = 'compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit'
// output from surefire; sadly the archive function in yetus only works on file names.
ARCHIVE_PATTERN_LIST = 'TEST-*.xml,org.apache.h*.txt,*.dumpstream,*.dump'
@@ -168,6 +168,7 @@ pipeline {
BUILD_URL_ARTIFACTS = "artifact/${WORKDIR_REL}/${PATCH_REL}"
DOCKERFILE = "${WORKDIR}/${DOCKERFILE_REL}"
YETUS_DRIVER = "${WORKDIR}/${YETUS_DRIVER_REL}"
+ SKIP_ERRORPRONE = "yes"
}
steps {
dir("${SOURCEDIR}") {
@@ -268,6 +269,7 @@ pipeline {
BUILD_URL_ARTIFACTS = "artifact/${WORKDIR_REL}/${PATCH_REL}"
DOCKERFILE = "${WORKDIR}/${DOCKERFILE_REL}"
YETUS_DRIVER = "${WORKDIR}/${YETUS_DRIVER_REL}"
+ SKIP_ERRORPRONE = "yes"
}
steps {
dir("${SOURCEDIR}") {
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 69e7720..5211ae1 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -831,7 +831,7 @@ function hbase_javac_logfilter
declare input=$1
declare output=$2
- ${GREP} -E '\[(ERROR|WARNING)\] /.*\.java:' "${input}" | sort > "${output}"
+ ${GREP} -E '\[ERROR\] /.*\.java:' "${input}" | sort > "${output}"
}
## This is named so that yetus will check us right after running tests.
diff --git a/dev-support/jenkins_precommit_github_yetus.sh b/dev-support/jenkins_precommit_github_yetus.sh
index 1c489d6..258b0ff 100755
--- a/dev-support/jenkins_precommit_github_yetus.sh
+++ b/dev-support/jenkins_precommit_github_yetus.sh
@@ -122,7 +122,10 @@ YETUS_ARGS+=("--whitespace-tabs-ignore-list=.*/generated/.*")
YETUS_ARGS+=("--tests-filter=${TESTS_FILTER}")
YETUS_ARGS+=("--personality=${SOURCEDIR}/dev-support/hbase-personality.sh")
YETUS_ARGS+=("--quick-hadoopcheck")
-YETUS_ARGS+=("--skip-errorprone")
+if [[ -n "${SKIP_ERRORPRONE}" ]]; then
+ # skip error prone
+ YETUS_ARGS+=("--skip-errorprone")
+fi
# effectively treat dev-support as a custom maven module
YETUS_ARGS+=("--skip-dirs=dev-support")
# For testing with specific hadoop version. Activates corresponding profile in maven runs.