You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by David Forsythe <df...@gmail.com> on 2016/12/15 09:16:37 UTC
Review Request 54775: Made /dev/urandom the fill source in
disk_full_framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54775/
-----------------------------------------------------------
Review request for mesos and Ian Downes.
Bugs: MESOS-6776
https://issues.apache.org/jira/browse/MESOS-6776
Repository: mesos
Description
-------
Made /dev/urandom the fill source in disk_full_framework.
When /dev/zero is used to fill on filesystems that support compression (like ZFS), the framework doesn't behave as desired.
Diffs
-----
src/examples/disk_full_framework.cpp e13d4c8a427905793dda9bb01c52b6d372c19150
Diff: https://reviews.apache.org/r/54775/diff/
Testing
-------
gmake check
Thanks,
David Forsythe
Re: Review Request 54775: Made /dev/urandom the fill source in
disk_full_framework.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54775/#review159318
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54636, 54775]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 15, 2016, 9:16 a.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54775/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 9:16 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-6776
> https://issues.apache.org/jira/browse/MESOS-6776
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made /dev/urandom the fill source in disk_full_framework.
>
> When /dev/zero is used to fill on filesystems that support compression (like ZFS), the framework doesn't behave as desired.
>
>
> Diffs
> -----
>
> src/examples/disk_full_framework.cpp e13d4c8a427905793dda9bb01c52b6d372c19150
>
> Diff: https://reviews.apache.org/r/54775/diff/
>
>
> Testing
> -------
>
> gmake check
>
>
> Thanks,
>
> David Forsythe
>
>