[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7288: SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on code in PR #7288:
URL: https://github.com/apache/cloudstack/pull/7288#discussion_r1187265200


##########
systemvm/agent/scripts/ipfirewall.sh:
##########
@@ -32,7 +32,7 @@ config_htaccess() {
 }
 
 ips(){
-  echo "allow from $1" >> $HTACCESS
+  grep "^allow from $1$" $HTACCESS || echo "allow from $1" >> $HTACCESS

Review Comment:
   to be sure 
   ```suggestion
     grep -e "^allow from $1$" $HTACCESS || echo "allow from $1" >> $HTACCESS
   ```
   ??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org