[GitHub] [activemq-artemis] gemmellr commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

[GitBox <gi...@apache.org>]

gemmellr commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP
URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-479986758
 
 
   I'd guess that Tim probably meant that doing it in the broker still requires the application to generate unique details per message (as it would if deduping entirely on its own), but even with the broker de-duping the production based on such property there are still cases consumption (+ production) duplicates can occur, so folks concerned with duplicates likely still need to take steps to handle that themselves to some extent regardless.
   
   Service Bus dedupes based on the AMQP message-id field as far as I know. Uniquely identifying a message is the reason that field exists. Its use doesn't align that well with JMS applications though since JMS mandates the client sets the message-id on send. Arguably calling send multiple times is in fact 'sending a different message' so thats not particularly unreasonable...but back to application-level identification for de-duplication usage either way.
   
   For consistency among different clients it would probably be nice if the broker supported its artemis-specific property, but similarly it might be nice to support using the message-id field in the intended manner. Using either will require decoding the section its in ('properties' for message-id, 'application properties' for the obvious) if it wasn't already done so, which could add some overhead. Perhaps an enabling toggle would be an idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services