You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by kr...@apache.org on 2025/12/05 10:58:19 UTC
(avro-rs) branch fix/dont_write_avro_codec_null created (now 319d832)
This is an automated email from the ASF dual-hosted git repository.
kriskras99 pushed a change to branch fix/dont_write_avro_codec_null
in repository https://gitbox.apache.org/repos/asf/avro-rs.git
at 319d832 fix: Don't write avro.codec if codec is Null
This branch includes the following new commits:
new 319d832 fix: Don't write avro.codec if codec is Null
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(avro-rs) 01/01: fix: Don't write avro.codec if codec is Null
Posted by kr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kriskras99 pushed a commit to branch fix/dont_write_avro_codec_null
in repository https://gitbox.apache.org/repos/asf/avro-rs.git
commit 319d8326c4caaa947b04f8fcd891229f0844fbe4
Author: Kriskras99 <gi...@kriskras99.nl>
AuthorDate: Fri Dec 5 11:58:11 2025 +0100
fix: Don't write avro.codec if codec is Null
---
avro/src/writer.rs | 12 +++++++-----
avro/tests/schema.rs | 2 +-
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/avro/src/writer.rs b/avro/src/writer.rs
index 31fb5c7..3b62b16 100644
--- a/avro/src/writer.rs
+++ b/avro/src/writer.rs
@@ -439,7 +439,9 @@ impl<'a, W: Write> Writer<'a, W> {
let mut metadata = HashMap::with_capacity(2);
metadata.insert("avro.schema", Value::Bytes(schema_bytes));
- metadata.insert("avro.codec", self.codec.into());
+ if self.codec != Codec::Null {
+ metadata.insert("avro.codec", self.codec.into());
+ }
match self.codec {
#[cfg(feature = "bzip")]
Codec::Bzip2(settings) => {
@@ -865,7 +867,7 @@ mod tests {
let mut writer = Writer::new(&schema, Vec::new())?;
writer.flush()?;
let result = writer.into_inner()?;
- assert_eq!(result.len(), 163);
+ assert_eq!(result.len(), 147);
// Unless the user indicates via the builder that the header has already been written
let mut writer = Writer::builder()
@@ -1341,7 +1343,7 @@ mod tests {
writer.flush()?;
let result = writer.into_inner()?;
- assert_eq!(result.len(), 260);
+ assert_eq!(result.len(), 244);
Ok(())
}
@@ -1617,7 +1619,7 @@ mod tests {
let bytes = writer.append_ser(conf)?;
- assert_eq!(198, bytes);
+ assert_eq!(182, bytes);
Ok(())
}
@@ -1707,7 +1709,7 @@ mod tests {
assert_eq!(
shared_buffer.len(),
- 167,
+ 151,
"the test buffer was not fully written to after Writer::flush was called"
);
diff --git a/avro/tests/schema.rs b/avro/tests/schema.rs
index 3c34230..be89102 100644
--- a/avro/tests/schema.rs
+++ b/avro/tests/schema.rs
@@ -816,7 +816,7 @@ fn test_record_schema_with_cyclic_references() -> TestResult {
panic!("An error occurred while writing datum: {err:?}")
}
let bytes = writer.into_inner()?;
- assert_eq!(316, bytes.len());
+ assert_eq!(300, bytes.len());
match Reader::new(&mut bytes.as_slice()) {
Ok(mut reader) => match reader.next() {