You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/06/22 21:47:47 UTC
[native-toolchain-CR] IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18655
Change subject: IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
......................................................................
IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
Large C++ projects can saturate large machines. When
the docker build infrastructures runs multiple builds
in parallel, it can overload the machine and cause
high memory usage / instability.
This adds "--load-average" to the make commands for three
large projects: GCC, LLVM, and Kudu. This can be tuned
later to get higher utilization.
Change-Id: I621e3f994d0266557e0a3d93ce329e36a90b7ae6
---
M source/gcc/build.sh
M source/kudu/build.sh
M source/llvm/build-source-tarball.sh
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/55/18655/1
--
To view, visit http://gerrit.cloudera.org:8080/18655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I621e3f994d0266557e0a3d93ce329e36a90b7ae6
Gerrit-Change-Number: 18655
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18655 )
Change subject: IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I621e3f994d0266557e0a3d93ce329e36a90b7ae6
Gerrit-Change-Number: 18655
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 22:07:49 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18655 )
Change subject: IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I621e3f994d0266557e0a3d93ce329e36a90b7ae6
Gerrit-Change-Number: 18655
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 21:02:21 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18655 )
Change subject: IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
......................................................................
IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
Large C++ projects can saturate large machines. When
the docker build infrastructures runs multiple builds
in parallel, it can overload the machine and cause
high memory usage / instability.
This adds "--load-average" to the make commands for three
large projects: GCC, LLVM, and Kudu. This can be tuned
later to get higher utilization.
Change-Id: I621e3f994d0266557e0a3d93ce329e36a90b7ae6
Reviewed-on: http://gerrit.cloudera.org:8080/18655
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M source/gcc/build.sh
M source/kudu/build.sh
M source/llvm/build-source-tarball.sh
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, but someone else must approve
Riza Suminto: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I621e3f994d0266557e0a3d93ce329e36a90b7ae6
Gerrit-Change-Number: 18655
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18655 )
Change subject: IMPALA-11370: Run make with --load-average for GCC, LLVM, and Kudu
......................................................................
Patch Set 1: Code-Review+1
Looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/18655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I621e3f994d0266557e0a3d93ce329e36a90b7ae6
Gerrit-Change-Number: 18655
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 22:28:22 +0000
Gerrit-HasComments: No