[jira] [Commented] (COUCHDB-3057) Add a sleep function for couchjs test suite tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373627#comment-15373627 ] 

ASF GitHub Bot commented on COUCHDB-3057:
-----------------------------------------

GitHub user davisp opened a pull request:

    https://github.com/apache/couchdb-couch/pull/183

    Add sleep as a test suite function

    This adds a class of test suite functions that are only available when a
    command line switch is passed to couchjs. This so that the JavaScript
    test suite has access to some helpful additional functions that aren't
    part of the JavaScript language.
    
    This particular change only adds a single `sleep` function which takes a
    single argument as the number of milliseconds to sleep.
    
    COUCHDB-3057
    
    
    ---
    
    And a demonstration:
    
    
        $ ./bin/couchjs -
        sleep(5);
        ReferenceError: sleep is not defined
        Stacktrace:
        	@-:1
        Failed to execute script.
        $ ./bin/couchjs -T -
        sleep(5000);
        ^D
        davisp@cylinder master $ echo $?
        0


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch 3057-add-couch-js-sleep-test-suite-helper

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
    
----
commit 367f4b6a7977e83026e8d1823bad9d01b9203579
Author: Paul J. Davis <pa...@gmail.com>
Date:   2016-07-12T20:13:47Z

    Add sleep as a test suite function
    
    This adds a class of test suite functions that are only available when a
    command line switch is passed to couchjs. This so that the JavaScript
    test suite has access to some helpful additional functions that aren't
    part of the JavaScript language.
    
    This particular change only adds a single `sleep` function which takes a
    single argument as the number of milliseconds to sleep.
    
    COUCHDB-3057

----


> Add a sleep function for couchjs test suite tests
> -------------------------------------------------
>
>                 Key: COUCHDB-3057
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3057
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: JavaScript View Server
>            Reporter: Paul Joseph Davis
>
> CouchJS does not have a sleep function exposed which means it does silly things like request the root url in a tight loop until a timeout is reached.
> So it'd be a good idea to add some of these things as C functions to prevent silliness in test suites.
> So far this just includes a sleep function that takes a single argument as the number of millseconds to sleep before resuming execution. This is accomplished using Sleep on Windows and usleep on everything else.
> These test functions are tied to the presence of a command line switch so that we can ensure that they are not enabled and available to view server scripts by default. The help message has a helpful note to *not* enable these for production systems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)