You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/10 06:27:55 UTC

[GitHub] [flink-ml] zhipeng93 commented on pull request #96: [hotfix] Bucketizer split point search

zhipeng93 commented on PR #96:
URL: https://github.com/apache/flink-ml/pull/96#issuecomment-1121980771

   Thanks for the fix @mumuhhh ! LGTM.
   
   Two minor comments:
   - Could you add a unit test that the number of inputCols is not the same as number splits?
   - Could you re-polish the commit message, such as `[hotfix] Fix finding buckets error in Bucketizer`? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org