You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by bbende <gi...@git.apache.org> on 2016/12/12 16:18:58 UTC
[GitHub] nifi pull request #1320: NIFI-2585 Add attributes to track s2s host and port
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/1320
NIFI-2585 Add attributes to track s2s host and port
I left the three commits to show the history of how this evolved. We can squash my two commits when merging, but I wanted Randy to get credit for starting the work on this ticket.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-2585
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1320.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1320
----
commit c6f0621f985b6deddadc616307f192c1ddf1060d
Author: Randy Gelhausen <rg...@gmail.com>
Date: 2016-12-07T07:18:09Z
NIFI-2585: Add attributes to track where a flow file came from when receiving over site-to-site
commit 841c4c80e42f09e7dc96552c661dde5a81ab7c08
Author: Bryan Bende <bb...@apache.org>
Date: 2016-12-08T20:17:06Z
NIFI-2585 Moving attributes into loop in AbstractFlowFileServerProtocol, and also updating StandardRemoteGroupPort to apply the same attributes when doing a pull-based site-to-site.
commit 0e3a29984d1abf94ba86d98fbe283e9671de1671
Author: Bryan Bende <bb...@apache.org>
Date: 2016-12-12T14:19:22Z
NIFI-2585 Adding checks in case host and port are not known
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1320: NIFI-2585 Add attributes to track s2s host and port
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1320
@ijokarumawak since you have worked with a lot of the s2s code, would you be able to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1320: NIFI-2585 Add attributes to track s2s host and port
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1320
Created another PR #1342, to describe my concerns and possible solutions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1320: NIFI-2585 Add attributes to track s2s host and port
Posted by bbende <gi...@git.apache.org>.
Github user bbende closed the pull request at:
https://github.com/apache/nifi/pull/1320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1320: NIFI-2585 Add attributes to track s2s host and port
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1320
@bbende @randerzander
Thanks for proposing this feature, it'll be useful!
Started reviewing this, and noticed few things.
1. Difference between RAW and HTTP protocol for receiving data.
RAW resolves hostname from socket, while HTTP does so from HTTP request. Due to this difference, RAW uses hostname as `s2s.host` attribute like `localhost`, while HTTP set `127.0.0.1`. I think this may be difficult when users define routing rules in downstream flow. I wonder if it can produce the same value, hostname or ip address for both transport protocol.
2. Unknown hostname and port due to illegal URL
As discussed in the [previous PR](https://github.com/apache/nifi/pull/1307#issuecomment-266442657), I got 'unknown' hostname and port with Docker containers. While this can be handled as a corner case since it's not allowed by the URL specification, I think it'd be better if we can be lenient here to support Docker environment. I confirmed provenance event also failed to resolve hostname and produced provenance details with `null` hostname.
I think this can be improved by changing Peer's constructor. It parses peerUrl then use its hostname and port, but the same information should be retrieved from PeerDescriptor without parsing the URL. Currently, SocketRemoteSiteListener uses server's hostname and port for PeerDescription, but it seems it's not correct, those should be client's.
Please let me dig deeper comments above. Will update soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1320: NIFI-2585 Add attributes to track s2s host and port
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1320
@bbende Sure, I will review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---