[GitHub] [kafka] dajac commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

[GitBox <gi...@apache.org>]

dajac commented on a change in pull request #11301:
URL: https://github.com/apache/kafka/pull/11301#discussion_r703030864



##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java
##########
@@ -32,9 +31,9 @@
  */
 @InterfaceStability.Evolving
 public class DeleteConsumerGroupsResult {
-    private final Map<CoordinatorKey, KafkaFutureImpl<Void>> futures;
+    private final Map<CoordinatorKey, KafkaFuture<Void>> futures;
 
-    DeleteConsumerGroupsResult(final Map<CoordinatorKey, KafkaFutureImpl<Void>> futures) {
+    DeleteConsumerGroupsResult(final Map<CoordinatorKey, KafkaFuture<Void>> futures) {

Review comment:
       Should we also remove CoordinatorKey here to remain consistent? This is less important because this constructor is not public.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org