[jira] [Commented] (MESOS-1291) Use clang-format to automatically format code to style

["Dominic Hamon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118957#comment-14118957 ] 

Dominic Hamon commented on MESOS-1291:
--------------------------------------

This has come up again as a patch (thanks, [~mpark]) has been put up for review (https://reviews.apache.org/r/25275/) to integrate clang-format.

Given that clang-format will mean consistency without having to actually learn the format rules, I propose that we move forward with the clang-format 3.5 version only and adopt that as the standard. We can then (gradually) format the files as they're edited and never think about style nits again.

This does mean that our style will change a bit from how it is now, so maybe some examples would be useful. A before and after for some relatively complex file would be good to attach to ensure that the changes aren't too egregious.

Thoughts?

> Use clang-format to automatically format code to style
> ------------------------------------------------------
>
>                 Key: MESOS-1291
>                 URL: https://issues.apache.org/jira/browse/MESOS-1291
>             Project: Mesos
>          Issue Type: Improvement
>          Components: technical debt
>            Reporter: Dominic Hamon
>              Labels: style
>
> Instead of relying on a script to check and report style errors, we should move to a workflow that allows people to write code how they feel comfortable and then automatically format it to conform to our style guide.
> The Chromium style from clang-format (http://clang.llvm.org/docs/ClangFormat.html) is very close to our style except for the dropped braces on class, struct, and function definitions, and two lines of whitespace between method definitions outside a class. As such, we should consider adopting clang-format and patching it to include a Mesos style variant.
> It can be run as part of post-reviews or as a git commit hook, or manually from within editors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)