You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/30 05:19:26 UTC
[GitHub] [dubbo] guohao opened a new pull request #8637: [3.0-Triple] Remove operation handler
guohao opened a new pull request #8637:
URL: https://github.com/apache/dubbo/pull/8637
## What is the purpose of the change
Remove unused OpertionHandler
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8637: [3.0-Triple] Remove operation handler
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8637:
URL: https://github.com/apache/dubbo/pull/8637#issuecomment-908072232
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8637](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83caefd) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3ac0c3704636d28af4fe3a2473cc6fa62903239d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ac0c37) will **decrease** coverage by `0.12%`.
> The diff coverage is `37.50%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8637/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8637 +/- ##
============================================
- Coverage 62.88% 62.76% -0.13%
+ Complexity 312 311 -1
============================================
Files 1118 1118
Lines 46840 46827 -13
Branches 7052 7052
============================================
- Hits 29457 29392 -65
- Misses 14087 14135 +48
- Partials 3296 3300 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ubbo/rpc/protocol/tri/ServerTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `100.00% <ø> (+4.54%)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-87.50%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.80% <ø> (ø)` | |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `39.64% <11.76%> (ø)` | |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `41.02% <66.66%> (ø)` | |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `39.44% <66.66%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ac0c37...83caefd](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao merged pull request #8637: [3.0-Triple] Remove operation handler
Posted by GitBox <gi...@apache.org>.
guohao merged pull request #8637:
URL: https://github.com/apache/dubbo/pull/8637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8637: [3.0-Triple] Remove operation handler
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8637:
URL: https://github.com/apache/dubbo/pull/8637#issuecomment-908072232
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8637](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83caefd) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3ac0c3704636d28af4fe3a2473cc6fa62903239d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ac0c37) will **increase** coverage by `0.07%`.
> The diff coverage is `37.50%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8637/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8637 +/- ##
============================================
+ Coverage 62.88% 62.95% +0.07%
Complexity 312 312
============================================
Files 1118 1118
Lines 46840 46827 -13
Branches 7052 7052
============================================
+ Hits 29457 29482 +25
+ Misses 14087 14053 -34
+ Partials 3296 3292 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ubbo/rpc/protocol/tri/ServerTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `100.00% <ø> (+4.54%)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-87.50%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.80% <ø> (ø)` | |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `39.64% <11.76%> (ø)` | |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `41.02% <66.66%> (ø)` | |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `39.44% <66.66%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ac0c37...83caefd](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #8637: [3.0-Triple] Remove operation handler
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8637:
URL: https://github.com/apache/dubbo/pull/8637#issuecomment-908072232
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8637](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83caefd) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3ac0c3704636d28af4fe3a2473cc6fa62903239d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ac0c37) will **decrease** coverage by `0.15%`.
> The diff coverage is `37.50%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8637/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8637 +/- ##
============================================
- Coverage 62.88% 62.73% -0.16%
+ Complexity 312 311 -1
============================================
Files 1118 1118
Lines 46840 46781 -59
Branches 7052 7018 -34
============================================
- Hits 29457 29346 -111
- Misses 14087 14133 +46
- Partials 3296 3302 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ubbo/rpc/protocol/tri/ServerTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `100.00% <ø> (+4.54%)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-87.50%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.80% <ø> (ø)` | |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `39.64% <11.76%> (ø)` | |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `41.02% <66.66%> (ø)` | |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `39.44% <66.66%> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ac0c37...83caefd](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8637: [3.0-Triple] Remove operation handler
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8637:
URL: https://github.com/apache/dubbo/pull/8637#issuecomment-908072232
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8637](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83caefd) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3ac0c3704636d28af4fe3a2473cc6fa62903239d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ac0c37) will **increase** coverage by `0.04%`.
> The diff coverage is `37.50%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8637/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8637 +/- ##
============================================
+ Coverage 62.88% 62.93% +0.04%
Complexity 312 312
============================================
Files 1118 1118
Lines 46840 46827 -13
Branches 7052 7052
============================================
+ Hits 29457 29470 +13
+ Misses 14087 14063 -24
+ Partials 3296 3294 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ubbo/rpc/protocol/tri/ServerTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `100.00% <ø> (+4.54%)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ache/dubbo/rpc/protocol/tri/TransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-87.50%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `25.80% <ø> (ø)` | |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `39.64% <11.76%> (ø)` | |
| [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `41.02% <66.66%> (ø)` | |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `39.44% <66.66%> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/dubbo/pull/8637/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ac0c37...83caefd](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org