You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "reuvenlax (GitHub)" <gi...@apache.org> on 2018/08/23 18:22:48 UTC
[GitHub] [beam] reuvenlax opened pull request #6268: [BEAM-5092]
Prevent hash-lookup of schema on every record
In many cases, we know that an instance of FieldValueGetterFactory is always called with the same type. In this scenario, we can cache the value of the first call.
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] reuvenlax commented on issue #6268: [BEAM-5092]
Prevent hash-lookup of schema on every record
Posted by "reuvenlax (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #6268: [BEAM-5092]
Prevent hash-lookup of schema on every record
Posted by "apilloud (GitHub)" <gi...@apache.org>.
The `fieldValueGetterFactory` could be expensive to create. Can you create this once and store it in the class?
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] reuvenlax commented on issue #6268: [BEAM-5092]
Prevent hash-lookup of schema on every record
Posted by "reuvenlax (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] tweise closed pull request #6268: [BEAM-5092] Prevent
hash-lookup of schema on every record
Posted by "tweise (GitHub)" <gi...@apache.org>.
[ pull request closed by tweise ]
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] reuvenlax commented on issue #6268: [BEAM-5092]
Prevent hash-lookup of schema on every record
Posted by "reuvenlax (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #6268:
[BEAM-5092] Prevent hash-lookup of schema on every record
Posted by "reuvenlax (GitHub)" <gi...@apache.org>.
Done
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] reuvenlax commented on issue #6268: [BEAM-5092]
Prevent hash-lookup of schema on every record
Posted by "reuvenlax (GitHub)" <gi...@apache.org>.
Appears that this breaks nested schemas. Looking into it.
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #6268: [BEAM-5092]
Prevent hash-lookup of schema on every record
Posted by "apilloud (GitHub)" <gi...@apache.org>.
This approach isn't thread safe. Seems like that is a problem, but I'm not quite sure of the lifecycle here. Should this be a `ConcurrentHashMap` created along with the getterFactory?
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #6268:
[BEAM-5092] Prevent hash-lookup of schema on every record
Posted by "reuvenlax (GitHub)" <gi...@apache.org>.
Done
[ Full content available at: https://github.com/apache/beam/pull/6268 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org