You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "suzhiking (via GitHub)" <gi...@apache.org> on 2026/04/23 15:45:59 UTC

[PR] KAFKA-20523: Fix logger class name in KStreamKTableJoinProcessor [kafka]

suzhiking opened a new pull request, #22132:
URL: https://github.com/apache/kafka/pull/22132

   Fix logger class name in `KStreamKTableJoinProcessor` — it was initialized with `KStreamKTableJoin.class` (the `ProcessorSupplier`) instead of its own class, so warnings like `Skipping record due to null join key or value` were logged under the wrong logger name and were effectively invisible when grepping for `KStreamKTableJoinProcessor`.
   
   One-line change: pass `KStreamKTableJoinProcessor.class` to `LoggerFactory.getLogger`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20523: Fix logger class name in KStreamKTableJoinProcessor [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22132:
URL: https://github.com/apache/kafka/pull/22132#issuecomment-4357807914

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20523: Fix logger class name in KStreamKTableJoinProcessor [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #22132:
URL: https://github.com/apache/kafka/pull/22132#issuecomment-4401863990

   Thanks for the fix. Merged to `trunk`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20523: Fix logger class name in KStreamKTableJoinProcessor [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #22132:
URL: https://github.com/apache/kafka/pull/22132#issuecomment-4401861758

   Failing test `OuterJoinListValueStoreRestorationTest` -- was fixed in the meantime already -- this PR was opened 2 weeks ago, to I believe it tests against an older trunk baseline. Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20523: Fix logger class name in KStreamKTableJoinProcessor [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #22132:
URL: https://github.com/apache/kafka/pull/22132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org