You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/03 15:09:10 UTC

[GitHub] [airflow] ojongyolandtaku opened a new pull request #8098: AIRFLOW-2644 - Allow wild-cards in the search box in the UI

ojongyolandtaku opened a new pull request #8098: AIRFLOW-2644 - Allow wild-cards in the search box in the UI
URL: https://github.com/apache/airflow/pull/8098
 
 
     Allow support of wildcards mainly for *. If i have a Dag name called example and i search for ex*, it should show example in the list.
     I use regular expression to allow wildcards. Regular expressions are used to identify without a pattern exist in a given sequence or not.
     I use the findall() function which returns the list containing all matches.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on issue #8098: AIRFLOW-2644 - Allow wild-cards in the search box in the UI

Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #8098: AIRFLOW-2644 - Allow wild-cards in the search box in the UI
URL: https://github.com/apache/airflow/pull/8098#issuecomment-610608349
 
 
   @ojongyolandtaku thank you for this PR. Could you please post before/after photos?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ojongyolandtaku commented on issue #8098: AIRFLOW-2644 - Allow wild-cards in the search box in the UI

Posted by GitBox <gi...@apache.org>.
ojongyolandtaku commented on issue #8098: AIRFLOW-2644 - Allow wild-cards in the search box in the UI
URL: https://github.com/apache/airflow/pull/8098#issuecomment-613974550
 
 
   okay sir.. i will do it
   
   On Tue, Apr 7, 2020 at 1:38 PM Daniel Imberman <no...@github.com>
   wrote:
   
   > @ojongyolandtaku <https://github.com/ojongyolandtaku> thank you for this
   > PR. Could you please post before/after photos?
   >
   > β€”
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/pull/8098#issuecomment-610608349>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AF2YLRVE5YQS5FWOBV27J7DRLOFNRANCNFSM4L4EQL4Q>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8098: AIRFLOW-2644 - Allow wild-cards in the search box in the UI

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8098: AIRFLOW-2644 - Allow wild-cards in the search box in the UI
URL: https://github.com/apache/airflow/pull/8098#issuecomment-608496069
 
 
   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better πŸš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://apache-airflow-slack.herokuapp.com/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services