You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/12 09:11:07 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #16008: [fix][env] Support the java version like 'XX-internal' in env file

lhotari commented on code in PR #16008:
URL: https://github.com/apache/pulsar/pull/16008#discussion_r895139457


##########
conf/pulsar_env.sh:
##########
@@ -60,6 +60,10 @@ for token in $("$JAVA_BIN" -version 2>&1 | grep 'version "'); do
           JAVA_MAJOR_VERSION=${BASH_REMATCH[1]}
         fi
         break
+    elif [[ $token =~ \"([[:digit:]]+)(.*)\" ]]; then

Review Comment:
   I think it's better to include `-internal` as part of the pattern to make this explicit. 
   
   The version parsing logic is also duplicated in bkenv.sh. That would need to be addressed too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org