You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2023/12/11 04:25:09 UTC
[I] Use `Type` when converting from `Literal` to `JsonValue`. [iceberg-rust]
liurenjie1024 opened a new issue, #117:
URL: https://github.com/apache/iceberg-rust/issues/117
Currently in [our conversion from `Literal` to `JsonValue`](https://github.com/apache/iceberg-rust/blob/28d7006ba3af12b1f99dc078780b08ccdd8e93b1/crates/iceberg/src/spec/values.rs#L510), we used stored type information in `Literal`. Per discussion in https://github.com/apache/iceberg-rust/issues/77 , we decided to remove type information stored in literal, so we should remove current implementation, and add another method with following signature:
```
fn try_into_json(self, data_type: &Type) -> Result<JsonValue>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Use `Type` when converting from `Literal` to `JsonValue`. [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #117: Use `Type` when converting from `Literal` to `JsonValue`.
URL: https://github.com/apache/iceberg-rust/issues/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org