You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/10/23 03:26:46 UTC

[GitHub] [datasketches-java] leerho commented on pull request #371: Tuple updatable ser de deprecation

leerho commented on pull request #371:
URL: https://github.com/apache/datasketches-java/pull/371#issuecomment-950049369


   This PR is to cleanup master in preparation for some more important PRs
   - Remove unused imports
   - Finish javadocs and annotations for the deprecation of SerDe of Tuple UpdatableSketch. -- no code changes. This will also serve as a signal to the community our intent to eventually deprecate this feature:
   
   1. It significantly complicates our codebase
   2. Users should be using the SerDe of the CompactSketch instead of SerDe of the UpdatableSketch.  It is cleaner, faster and smaller.
   3. Nonetheless, if we hear back from the community that this is really needed, we will reconsider.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org