You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "eliaperantoni (via GitHub)" <gi...@apache.org> on 2025/06/18 07:45:17 UTC
[PR] Fix `impl Ord for Ident` [datafusion-sqlparser-rs]
eliaperantoni opened a new pull request, #1893:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1893
At the moment, the `Span` of an `Ident` is used influences its ordering, but this doesn't seem consistent with the implementations of `PartialEq`, `Hash`, and the general guidelines for developing with `Span`: that they should be opaque information that doesn't influence the ordering or equality of the AST nodes. Which is the reason why `TokenWithSpan` was born.
This PR change the implementation of `Ord` to ensure that it doesn't depend on the `Span`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `impl Ord for Ident` [datafusion-sqlparser-rs]
Posted by "eliaperantoni (via GitHub)" <gi...@apache.org>.
eliaperantoni commented on PR #1893:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1893#issuecomment-2999065123
@iffyio Thank you for your feedback! I added a test and fixed the CI issues :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `impl Ord for Ident` [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1893:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1893#issuecomment-3004814250
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `impl Ord for Ident` [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on PR #1893:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1893#issuecomment-2991529806
Thanks @eliaperantoni! Could you add some test cases to demonstrate the behavior being fixed? (Also there's some CI failures on the branch that need adressing it seems)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `impl Ord for Ident` [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #1893:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org