You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/28 02:12:28 UTC

[GitHub] [hbase] Apache9 commented on pull request #2463: HBASE-25100 conf and conn are assigned twice in HBaseReplicationEndpo…

Apache9 commented on pull request #2463:
URL: https://github.com/apache/hbase/pull/2463#issuecomment-699731240


   I think we'd better revist the synchronization in HBaseReplicationEndpoint. I can see the conn field is used in getReplicationSink where it is synchronized, but actually it is only used to protect sinkServers? So we can just synchroniza on sinkServers or a dedicated locking object? And we also have synchronized when accessing ZKWatcher, need to find out whether they need to use the same lock.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org