You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mr-brobot (via GitHub)" <gi...@apache.org> on 2023/05/18 16:58:42 UTC

[GitHub] [arrow-rs] mr-brobot commented on pull request #4244: Subtract ts

mr-brobot commented on PR #4244:
URL: https://github.com/apache/arrow-rs/pull/4244#issuecomment-1553345696

   Some thoughts:
   - Lots of redundancy in the tests. I'd like to clean this up. Possibly with a macro to generate tests for each resolution?
   - Subtracting timestamps of different resolutions is not supported. It might make sense to support this by allowing the user to cast timestamps to different resolutions before calling `subtract_dyn` / `subtract_dyn_checked`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org