[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3533: Arrow: Fix vectorized position reader

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #3533:
URL: https://github.com/apache/iceberg/pull/3533#discussion_r747720844



##########
File path: arrow/src/main/java/org/apache/iceberg/arrow/vectorized/NullabilityHolder.java
##########
@@ -75,6 +77,7 @@ public int numNulls() {
   }
 
   public void reset() {
+    // TODO: do we have reset the values too?

Review comment:
       There are cases when we reuse the nullability holder and call `reset` and `setNotNulls(0, numValsToRead)`. It looks like we still have to invalidate the underlying values?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org