[GitHub] [flink] 1u0 edited a comment on issue #8513: [FLINK-12147] [metrics] Error for monitor kafka metrics when Use influxDB metr…

[GitBox <gi...@apache.org>]

1u0 edited a comment on issue #8513:  [FLINK-12147] [metrics] Error for monitor kafka metrics when Use influxDB metr…
URL: https://github.com/apache/flink/pull/8513#issuecomment-495108177
 
 
   The discussion and effort in InfluxDB project only confirm that one day InfluxDB service (in such future version) may accept NaN and infinite values as valid. (I consider this situation as an argument that influxdb client should handle it).
   
   If we land your changes here, delegating such filtering to library user, later, we would have to add another patch to pass those values to newer InfluxDB versioned services that support those values.
   This would involve InfluxDB service version checking, or dumping decision to Flink users via configuration parameter.
   
   Alternatively:
   as the client library user, I expect that the (official) library alleviates differences and feature capabilities of different server apis, so I can use the same user code against different server versions.
   The `influxdb-java` client **could** have added some configuration option, that would influence api mode:
    - "best effort" mode (desired here, in Flink influxdb reporter), when client silently drops measurement points if it knows that the backend service doesn't support values;
    - "transparent" mode (current client's behavior);
    - "strict" mode, when client throws exception on client side, if it knows that the backend service doesn't support some values.
   
   I encourage you to push such change in the `influxdb-java` client, rather than having a workaround here.
   If such change is adopted there, we can just bump corresponding client version here and add configuration (in code) if needed.
   
   Consider adding workaround here only as the last option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services