You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sagar <sa...@gmail.com> on 2022/02/12 07:44:12 UTC
Re: [VOTE] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"
Hi All,
There's another amendment proposed for this KIP. We are adding a new metric
type called *cache-size-bytes-total *to capture the cache size in bytes
accumulated by a task.
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
Thanks!
Sagar.
On Mon, Jan 24, 2022 at 7:55 AM Guozhang Wang <wa...@gmail.com> wrote:
> Thanks Sagar, I'm +1 on the renamed metric.
>
> On Sat, Jan 22, 2022 at 6:56 PM Sagar <sa...@gmail.com> wrote:
>
> > Hi All,
> >
> > There is a small update to the KIP whereby the newly introduced metric
> > *total-bytes
> > *has been renamed to *input-buffer-bytes-total.*
> >
> > Thanks!
> > Sagar.
> >
> > On Wed, Sep 29, 2021 at 9:57 AM Sagar <sa...@gmail.com> wrote:
> >
> > > We have 3 binding votes: Sophie/Guozhang/Mathias
> > > and 2 non-binding votes: Josep/Luke and no -1 votes.
> > >
> > > Marking this KIP as accepted.
> > >
> > > Thanks everyone!
> > >
> > > Thanks!
> > > Sagar.
> > >
> > >
> > >
> > > On Wed, Sep 29, 2021 at 7:18 AM Matthias J. Sax <mj...@apache.org>
> > wrote:
> > >
> > >> +1 (binding)
> > >>
> > >> On 9/28/21 10:40 AM, Sagar wrote:
> > >> > Hi All,
> > >> >
> > >> > Bumping this vote thread again!
> > >> >
> > >> > Thanks!
> > >> > Sagar.
> > >> >
> > >> > On Wed, Sep 8, 2021 at 1:19 PM Luke Chen <sh...@gmail.com> wrote:
> > >> >
> > >> >> Thanks for the KIP.
> > >> >>
> > >> >> + 1 (non-binding)
> > >> >>
> > >> >> Thanks.
> > >> >> Luke
> > >> >>
> > >> >> On Wed, Sep 8, 2021 at 2:48 PM Josep Prat
> > <josep.prat@aiven.io.invalid
> > >> >
> > >> >> wrote:
> > >> >>
> > >> >>> +1 (non binding).
> > >> >>>
> > >> >>> Thanks for the KIP Sagar!
> > >> >>> ———
> > >> >>> Josep Prat
> > >> >>>
> > >> >>> Aiven Deutschland GmbH
> > >> >>>
> > >> >>> Immanuelkirchstraße 26, 10405 Berlin
> > >> >>>
> > >> >>> Amtsgericht Charlottenburg, HRB 209739 B
> > >> >>>
> > >> >>> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> > >> >>>
> > >> >>> m: +491715557497
> > >> >>>
> > >> >>> w: aiven.io
> > >> >>>
> > >> >>> e: josep.prat@aiven.io
> > >> >>>
> > >> >>> On Wed, Sep 8, 2021, 03:29 Sophie Blee-Goldman
> > >> >> <sophie@confluent.io.invalid
> > >> >>>>
> > >> >>> wrote:
> > >> >>>
> > >> >>>> +1 (binding)
> > >> >>>>
> > >> >>>> Thanks for the KIP!
> > >> >>>>
> > >> >>>> -Sophie
> > >> >>>>
> > >> >>>> On Tue, Sep 7, 2021 at 1:59 PM Guozhang Wang <wangguoz@gmail.com
> >
> > >> >> wrote:
> > >> >>>>
> > >> >>>>> Thanks Sagar, +1 from me.
> > >> >>>>>
> > >> >>>>>
> > >> >>>>> Guozhang
> > >> >>>>>
> > >> >>>>> On Sat, Sep 4, 2021 at 10:29 AM Sagar <
> sagarmeansocean@gmail.com>
> > >> >>> wrote:
> > >> >>>>>
> > >> >>>>>> Hi All,
> > >> >>>>>>
> > >> >>>>>> I would like to start a vote on the following KIP:
> > >> >>>>>>
> > >> >>>>>>
> > >> >>>>>
> > >> >>>>
> > >> >>>
> > >> >>
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
> > >> >>>>>>
> > >> >>>>>> Thanks!
> > >> >>>>>> Sagar.
> > >> >>>>>>
> > >> >>>>>
> > >> >>>>>
> > >> >>>>> --
> > >> >>>>> -- Guozhang
> > >> >>>>>
> > >> >>>>
> > >> >>>
> > >> >>
> > >> >
> > >>
> > >
> >
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"
Posted by Guozhang Wang <wa...@gmail.com>.
Ah got it.
I'd suggest we keep it a task-level metric then.
On Mon, Feb 14, 2022 at 10:07 AM Sagar <sa...@gmail.com> wrote:
> Actually @Guozhang, I just realised I didn't frame my question properly.
> What I wanted to know what, should this be a task-level metric or a
> cache-level metric. Place of definition is one thing, but what kind of
> metric should it be is what I wanted to know.
>
> Thanks!
> Sagar.
>
> On Mon, Feb 14, 2022 at 8:28 AM Sagar <sa...@gmail.com> wrote:
>
> > Thanks Guozhang.
> >
> > Thanks!
> > Sagar.
> >
> > On Mon, Feb 14, 2022 at 7:40 AM Guozhang Wang <wa...@gmail.com>
> wrote:
> >
> >> Hi Sagar,
> >>
> >> Looks good to define it in the NamedCacheMetrics. Though since this is
> an
> >> internal implementation detail and neither of the classes are public, we
> >> do
> >> not actually need to define it in the KIP :)
> >>
> >>
> >> Guozhang
> >>
> >> On Sat, Feb 12, 2022 at 4:22 AM Sagar <sa...@gmail.com>
> wrote:
> >>
> >> > @Guozhang,
> >> >
> >> > I have sent an update to this KIP. I have a question though.. Should
> >> this
> >> > new metric be defined in TaskMetrics level or NamedCacheMetrics? I
> think
> >> > the latter makes sense as that holds the cache size at a task level
> and
> >> > exposes some other cache related metrics as well like hit-ratio.
> >> >
> >> > Thanks!
> >> > Sagar.
> >> >
> >> >
> >> > On Sat, Feb 12, 2022 at 1:14 PM Sagar <sa...@gmail.com>
> >> wrote:
> >> >
> >> > > Hi All,
> >> > >
> >> > > There's another amendment proposed for this KIP. We are adding a new
> >> > > metric type called *cache-size-bytes-total *to capture the cache
> >> size in
> >> > > bytes accumulated by a task.
> >> > >
> >> > >
> >> >
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
> >> > >
> >> > > Thanks!
> >> > > Sagar.
> >> > >
> >> > > On Mon, Jan 24, 2022 at 7:55 AM Guozhang Wang <wa...@gmail.com>
> >> > wrote:
> >> > >
> >> > >> Thanks Sagar, I'm +1 on the renamed metric.
> >> > >>
> >> > >> On Sat, Jan 22, 2022 at 6:56 PM Sagar <sa...@gmail.com>
> >> > wrote:
> >> > >>
> >> > >> > Hi All,
> >> > >> >
> >> > >> > There is a small update to the KIP whereby the newly introduced
> >> metric
> >> > >> > *total-bytes
> >> > >> > *has been renamed to *input-buffer-bytes-total.*
> >> > >> >
> >> > >> > Thanks!
> >> > >> > Sagar.
> >> > >> >
> >> > >> > On Wed, Sep 29, 2021 at 9:57 AM Sagar <sagarmeansocean@gmail.com
> >
> >> > >> wrote:
> >> > >> >
> >> > >> > > We have 3 binding votes: Sophie/Guozhang/Mathias
> >> > >> > > and 2 non-binding votes: Josep/Luke and no -1 votes.
> >> > >> > >
> >> > >> > > Marking this KIP as accepted.
> >> > >> > >
> >> > >> > > Thanks everyone!
> >> > >> > >
> >> > >> > > Thanks!
> >> > >> > > Sagar.
> >> > >> > >
> >> > >> > >
> >> > >> > >
> >> > >> > > On Wed, Sep 29, 2021 at 7:18 AM Matthias J. Sax <
> >> mjsax@apache.org>
> >> > >> > wrote:
> >> > >> > >
> >> > >> > >> +1 (binding)
> >> > >> > >>
> >> > >> > >> On 9/28/21 10:40 AM, Sagar wrote:
> >> > >> > >> > Hi All,
> >> > >> > >> >
> >> > >> > >> > Bumping this vote thread again!
> >> > >> > >> >
> >> > >> > >> > Thanks!
> >> > >> > >> > Sagar.
> >> > >> > >> >
> >> > >> > >> > On Wed, Sep 8, 2021 at 1:19 PM Luke Chen <showuon@gmail.com
> >
> >> > >> wrote:
> >> > >> > >> >
> >> > >> > >> >> Thanks for the KIP.
> >> > >> > >> >>
> >> > >> > >> >> + 1 (non-binding)
> >> > >> > >> >>
> >> > >> > >> >> Thanks.
> >> > >> > >> >> Luke
> >> > >> > >> >>
> >> > >> > >> >> On Wed, Sep 8, 2021 at 2:48 PM Josep Prat
> >> > >> > <josep.prat@aiven.io.invalid
> >> > >> > >> >
> >> > >> > >> >> wrote:
> >> > >> > >> >>
> >> > >> > >> >>> +1 (non binding).
> >> > >> > >> >>>
> >> > >> > >> >>> Thanks for the KIP Sagar!
> >> > >> > >> >>> ———
> >> > >> > >> >>> Josep Prat
> >> > >> > >> >>>
> >> > >> > >> >>> Aiven Deutschland GmbH
> >> > >> > >> >>>
> >> > >> > >> >>> Immanuelkirchstraße 26, 10405 Berlin
> >> > >> > >> >>>
> >> > >> > >> >>> Amtsgericht Charlottenburg, HRB 209739 B
> >> > >> > >> >>>
> >> > >> > >> >>> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> >> > >> > >> >>>
> >> > >> > >> >>> m: +491715557497
> >> > >> > >> >>>
> >> > >> > >> >>> w: aiven.io
> >> > >> > >> >>>
> >> > >> > >> >>> e: josep.prat@aiven.io
> >> > >> > >> >>>
> >> > >> > >> >>> On Wed, Sep 8, 2021, 03:29 Sophie Blee-Goldman
> >> > >> > >> >> <sophie@confluent.io.invalid
> >> > >> > >> >>>>
> >> > >> > >> >>> wrote:
> >> > >> > >> >>>
> >> > >> > >> >>>> +1 (binding)
> >> > >> > >> >>>>
> >> > >> > >> >>>> Thanks for the KIP!
> >> > >> > >> >>>>
> >> > >> > >> >>>> -Sophie
> >> > >> > >> >>>>
> >> > >> > >> >>>> On Tue, Sep 7, 2021 at 1:59 PM Guozhang Wang <
> >> > >> wangguoz@gmail.com>
> >> > >> > >> >> wrote:
> >> > >> > >> >>>>
> >> > >> > >> >>>>> Thanks Sagar, +1 from me.
> >> > >> > >> >>>>>
> >> > >> > >> >>>>>
> >> > >> > >> >>>>> Guozhang
> >> > >> > >> >>>>>
> >> > >> > >> >>>>> On Sat, Sep 4, 2021 at 10:29 AM Sagar <
> >> > >> sagarmeansocean@gmail.com>
> >> > >> > >> >>> wrote:
> >> > >> > >> >>>>>
> >> > >> > >> >>>>>> Hi All,
> >> > >> > >> >>>>>>
> >> > >> > >> >>>>>> I would like to start a vote on the following KIP:
> >> > >> > >> >>>>>>
> >> > >> > >> >>>>>>
> >> > >> > >> >>>>>
> >> > >> > >> >>>>
> >> > >> > >> >>>
> >> > >> > >> >>
> >> > >> > >>
> >> > >> >
> >> > >>
> >> >
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
> >> > >> > >> >>>>>>
> >> > >> > >> >>>>>> Thanks!
> >> > >> > >> >>>>>> Sagar.
> >> > >> > >> >>>>>>
> >> > >> > >> >>>>>
> >> > >> > >> >>>>>
> >> > >> > >> >>>>> --
> >> > >> > >> >>>>> -- Guozhang
> >> > >> > >> >>>>>
> >> > >> > >> >>>>
> >> > >> > >> >>>
> >> > >> > >> >>
> >> > >> > >> >
> >> > >> > >>
> >> > >> > >
> >> > >> >
> >> > >>
> >> > >>
> >> > >> --
> >> > >> -- Guozhang
> >> > >>
> >> > >
> >> >
> >>
> >>
> >> --
> >> -- Guozhang
> >>
> >
>
--
-- Guozhang
Re: [VOTE] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"
Posted by Sagar <sa...@gmail.com>.
Actually @Guozhang, I just realised I didn't frame my question properly.
What I wanted to know what, should this be a task-level metric or a
cache-level metric. Place of definition is one thing, but what kind of
metric should it be is what I wanted to know.
Thanks!
Sagar.
On Mon, Feb 14, 2022 at 8:28 AM Sagar <sa...@gmail.com> wrote:
> Thanks Guozhang.
>
> Thanks!
> Sagar.
>
> On Mon, Feb 14, 2022 at 7:40 AM Guozhang Wang <wa...@gmail.com> wrote:
>
>> Hi Sagar,
>>
>> Looks good to define it in the NamedCacheMetrics. Though since this is an
>> internal implementation detail and neither of the classes are public, we
>> do
>> not actually need to define it in the KIP :)
>>
>>
>> Guozhang
>>
>> On Sat, Feb 12, 2022 at 4:22 AM Sagar <sa...@gmail.com> wrote:
>>
>> > @Guozhang,
>> >
>> > I have sent an update to this KIP. I have a question though.. Should
>> this
>> > new metric be defined in TaskMetrics level or NamedCacheMetrics? I think
>> > the latter makes sense as that holds the cache size at a task level and
>> > exposes some other cache related metrics as well like hit-ratio.
>> >
>> > Thanks!
>> > Sagar.
>> >
>> >
>> > On Sat, Feb 12, 2022 at 1:14 PM Sagar <sa...@gmail.com>
>> wrote:
>> >
>> > > Hi All,
>> > >
>> > > There's another amendment proposed for this KIP. We are adding a new
>> > > metric type called *cache-size-bytes-total *to capture the cache
>> size in
>> > > bytes accumulated by a task.
>> > >
>> > >
>> >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
>> > >
>> > > Thanks!
>> > > Sagar.
>> > >
>> > > On Mon, Jan 24, 2022 at 7:55 AM Guozhang Wang <wa...@gmail.com>
>> > wrote:
>> > >
>> > >> Thanks Sagar, I'm +1 on the renamed metric.
>> > >>
>> > >> On Sat, Jan 22, 2022 at 6:56 PM Sagar <sa...@gmail.com>
>> > wrote:
>> > >>
>> > >> > Hi All,
>> > >> >
>> > >> > There is a small update to the KIP whereby the newly introduced
>> metric
>> > >> > *total-bytes
>> > >> > *has been renamed to *input-buffer-bytes-total.*
>> > >> >
>> > >> > Thanks!
>> > >> > Sagar.
>> > >> >
>> > >> > On Wed, Sep 29, 2021 at 9:57 AM Sagar <sa...@gmail.com>
>> > >> wrote:
>> > >> >
>> > >> > > We have 3 binding votes: Sophie/Guozhang/Mathias
>> > >> > > and 2 non-binding votes: Josep/Luke and no -1 votes.
>> > >> > >
>> > >> > > Marking this KIP as accepted.
>> > >> > >
>> > >> > > Thanks everyone!
>> > >> > >
>> > >> > > Thanks!
>> > >> > > Sagar.
>> > >> > >
>> > >> > >
>> > >> > >
>> > >> > > On Wed, Sep 29, 2021 at 7:18 AM Matthias J. Sax <
>> mjsax@apache.org>
>> > >> > wrote:
>> > >> > >
>> > >> > >> +1 (binding)
>> > >> > >>
>> > >> > >> On 9/28/21 10:40 AM, Sagar wrote:
>> > >> > >> > Hi All,
>> > >> > >> >
>> > >> > >> > Bumping this vote thread again!
>> > >> > >> >
>> > >> > >> > Thanks!
>> > >> > >> > Sagar.
>> > >> > >> >
>> > >> > >> > On Wed, Sep 8, 2021 at 1:19 PM Luke Chen <sh...@gmail.com>
>> > >> wrote:
>> > >> > >> >
>> > >> > >> >> Thanks for the KIP.
>> > >> > >> >>
>> > >> > >> >> + 1 (non-binding)
>> > >> > >> >>
>> > >> > >> >> Thanks.
>> > >> > >> >> Luke
>> > >> > >> >>
>> > >> > >> >> On Wed, Sep 8, 2021 at 2:48 PM Josep Prat
>> > >> > <josep.prat@aiven.io.invalid
>> > >> > >> >
>> > >> > >> >> wrote:
>> > >> > >> >>
>> > >> > >> >>> +1 (non binding).
>> > >> > >> >>>
>> > >> > >> >>> Thanks for the KIP Sagar!
>> > >> > >> >>> ———
>> > >> > >> >>> Josep Prat
>> > >> > >> >>>
>> > >> > >> >>> Aiven Deutschland GmbH
>> > >> > >> >>>
>> > >> > >> >>> Immanuelkirchstraße 26, 10405 Berlin
>> > >> > >> >>>
>> > >> > >> >>> Amtsgericht Charlottenburg, HRB 209739 B
>> > >> > >> >>>
>> > >> > >> >>> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
>> > >> > >> >>>
>> > >> > >> >>> m: +491715557497
>> > >> > >> >>>
>> > >> > >> >>> w: aiven.io
>> > >> > >> >>>
>> > >> > >> >>> e: josep.prat@aiven.io
>> > >> > >> >>>
>> > >> > >> >>> On Wed, Sep 8, 2021, 03:29 Sophie Blee-Goldman
>> > >> > >> >> <sophie@confluent.io.invalid
>> > >> > >> >>>>
>> > >> > >> >>> wrote:
>> > >> > >> >>>
>> > >> > >> >>>> +1 (binding)
>> > >> > >> >>>>
>> > >> > >> >>>> Thanks for the KIP!
>> > >> > >> >>>>
>> > >> > >> >>>> -Sophie
>> > >> > >> >>>>
>> > >> > >> >>>> On Tue, Sep 7, 2021 at 1:59 PM Guozhang Wang <
>> > >> wangguoz@gmail.com>
>> > >> > >> >> wrote:
>> > >> > >> >>>>
>> > >> > >> >>>>> Thanks Sagar, +1 from me.
>> > >> > >> >>>>>
>> > >> > >> >>>>>
>> > >> > >> >>>>> Guozhang
>> > >> > >> >>>>>
>> > >> > >> >>>>> On Sat, Sep 4, 2021 at 10:29 AM Sagar <
>> > >> sagarmeansocean@gmail.com>
>> > >> > >> >>> wrote:
>> > >> > >> >>>>>
>> > >> > >> >>>>>> Hi All,
>> > >> > >> >>>>>>
>> > >> > >> >>>>>> I would like to start a vote on the following KIP:
>> > >> > >> >>>>>>
>> > >> > >> >>>>>>
>> > >> > >> >>>>>
>> > >> > >> >>>>
>> > >> > >> >>>
>> > >> > >> >>
>> > >> > >>
>> > >> >
>> > >>
>> >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
>> > >> > >> >>>>>>
>> > >> > >> >>>>>> Thanks!
>> > >> > >> >>>>>> Sagar.
>> > >> > >> >>>>>>
>> > >> > >> >>>>>
>> > >> > >> >>>>>
>> > >> > >> >>>>> --
>> > >> > >> >>>>> -- Guozhang
>> > >> > >> >>>>>
>> > >> > >> >>>>
>> > >> > >> >>>
>> > >> > >> >>
>> > >> > >> >
>> > >> > >>
>> > >> > >
>> > >> >
>> > >>
>> > >>
>> > >> --
>> > >> -- Guozhang
>> > >>
>> > >
>> >
>>
>>
>> --
>> -- Guozhang
>>
>
Re: [VOTE] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"
Posted by Sagar <sa...@gmail.com>.
Thanks Guozhang.
Thanks!
Sagar.
On Mon, Feb 14, 2022 at 7:40 AM Guozhang Wang <wa...@gmail.com> wrote:
> Hi Sagar,
>
> Looks good to define it in the NamedCacheMetrics. Though since this is an
> internal implementation detail and neither of the classes are public, we do
> not actually need to define it in the KIP :)
>
>
> Guozhang
>
> On Sat, Feb 12, 2022 at 4:22 AM Sagar <sa...@gmail.com> wrote:
>
> > @Guozhang,
> >
> > I have sent an update to this KIP. I have a question though.. Should this
> > new metric be defined in TaskMetrics level or NamedCacheMetrics? I think
> > the latter makes sense as that holds the cache size at a task level and
> > exposes some other cache related metrics as well like hit-ratio.
> >
> > Thanks!
> > Sagar.
> >
> >
> > On Sat, Feb 12, 2022 at 1:14 PM Sagar <sa...@gmail.com> wrote:
> >
> > > Hi All,
> > >
> > > There's another amendment proposed for this KIP. We are adding a new
> > > metric type called *cache-size-bytes-total *to capture the cache size
> in
> > > bytes accumulated by a task.
> > >
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
> > >
> > > Thanks!
> > > Sagar.
> > >
> > > On Mon, Jan 24, 2022 at 7:55 AM Guozhang Wang <wa...@gmail.com>
> > wrote:
> > >
> > >> Thanks Sagar, I'm +1 on the renamed metric.
> > >>
> > >> On Sat, Jan 22, 2022 at 6:56 PM Sagar <sa...@gmail.com>
> > wrote:
> > >>
> > >> > Hi All,
> > >> >
> > >> > There is a small update to the KIP whereby the newly introduced
> metric
> > >> > *total-bytes
> > >> > *has been renamed to *input-buffer-bytes-total.*
> > >> >
> > >> > Thanks!
> > >> > Sagar.
> > >> >
> > >> > On Wed, Sep 29, 2021 at 9:57 AM Sagar <sa...@gmail.com>
> > >> wrote:
> > >> >
> > >> > > We have 3 binding votes: Sophie/Guozhang/Mathias
> > >> > > and 2 non-binding votes: Josep/Luke and no -1 votes.
> > >> > >
> > >> > > Marking this KIP as accepted.
> > >> > >
> > >> > > Thanks everyone!
> > >> > >
> > >> > > Thanks!
> > >> > > Sagar.
> > >> > >
> > >> > >
> > >> > >
> > >> > > On Wed, Sep 29, 2021 at 7:18 AM Matthias J. Sax <mjsax@apache.org
> >
> > >> > wrote:
> > >> > >
> > >> > >> +1 (binding)
> > >> > >>
> > >> > >> On 9/28/21 10:40 AM, Sagar wrote:
> > >> > >> > Hi All,
> > >> > >> >
> > >> > >> > Bumping this vote thread again!
> > >> > >> >
> > >> > >> > Thanks!
> > >> > >> > Sagar.
> > >> > >> >
> > >> > >> > On Wed, Sep 8, 2021 at 1:19 PM Luke Chen <sh...@gmail.com>
> > >> wrote:
> > >> > >> >
> > >> > >> >> Thanks for the KIP.
> > >> > >> >>
> > >> > >> >> + 1 (non-binding)
> > >> > >> >>
> > >> > >> >> Thanks.
> > >> > >> >> Luke
> > >> > >> >>
> > >> > >> >> On Wed, Sep 8, 2021 at 2:48 PM Josep Prat
> > >> > <josep.prat@aiven.io.invalid
> > >> > >> >
> > >> > >> >> wrote:
> > >> > >> >>
> > >> > >> >>> +1 (non binding).
> > >> > >> >>>
> > >> > >> >>> Thanks for the KIP Sagar!
> > >> > >> >>> ———
> > >> > >> >>> Josep Prat
> > >> > >> >>>
> > >> > >> >>> Aiven Deutschland GmbH
> > >> > >> >>>
> > >> > >> >>> Immanuelkirchstraße 26, 10405 Berlin
> > >> > >> >>>
> > >> > >> >>> Amtsgericht Charlottenburg, HRB 209739 B
> > >> > >> >>>
> > >> > >> >>> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> > >> > >> >>>
> > >> > >> >>> m: +491715557497
> > >> > >> >>>
> > >> > >> >>> w: aiven.io
> > >> > >> >>>
> > >> > >> >>> e: josep.prat@aiven.io
> > >> > >> >>>
> > >> > >> >>> On Wed, Sep 8, 2021, 03:29 Sophie Blee-Goldman
> > >> > >> >> <sophie@confluent.io.invalid
> > >> > >> >>>>
> > >> > >> >>> wrote:
> > >> > >> >>>
> > >> > >> >>>> +1 (binding)
> > >> > >> >>>>
> > >> > >> >>>> Thanks for the KIP!
> > >> > >> >>>>
> > >> > >> >>>> -Sophie
> > >> > >> >>>>
> > >> > >> >>>> On Tue, Sep 7, 2021 at 1:59 PM Guozhang Wang <
> > >> wangguoz@gmail.com>
> > >> > >> >> wrote:
> > >> > >> >>>>
> > >> > >> >>>>> Thanks Sagar, +1 from me.
> > >> > >> >>>>>
> > >> > >> >>>>>
> > >> > >> >>>>> Guozhang
> > >> > >> >>>>>
> > >> > >> >>>>> On Sat, Sep 4, 2021 at 10:29 AM Sagar <
> > >> sagarmeansocean@gmail.com>
> > >> > >> >>> wrote:
> > >> > >> >>>>>
> > >> > >> >>>>>> Hi All,
> > >> > >> >>>>>>
> > >> > >> >>>>>> I would like to start a vote on the following KIP:
> > >> > >> >>>>>>
> > >> > >> >>>>>>
> > >> > >> >>>>>
> > >> > >> >>>>
> > >> > >> >>>
> > >> > >> >>
> > >> > >>
> > >> >
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
> > >> > >> >>>>>>
> > >> > >> >>>>>> Thanks!
> > >> > >> >>>>>> Sagar.
> > >> > >> >>>>>>
> > >> > >> >>>>>
> > >> > >> >>>>>
> > >> > >> >>>>> --
> > >> > >> >>>>> -- Guozhang
> > >> > >> >>>>>
> > >> > >> >>>>
> > >> > >> >>>
> > >> > >> >>
> > >> > >> >
> > >> > >>
> > >> > >
> > >> >
> > >>
> > >>
> > >> --
> > >> -- Guozhang
> > >>
> > >
> >
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"
Posted by Guozhang Wang <wa...@gmail.com>.
Hi Sagar,
Looks good to define it in the NamedCacheMetrics. Though since this is an
internal implementation detail and neither of the classes are public, we do
not actually need to define it in the KIP :)
Guozhang
On Sat, Feb 12, 2022 at 4:22 AM Sagar <sa...@gmail.com> wrote:
> @Guozhang,
>
> I have sent an update to this KIP. I have a question though.. Should this
> new metric be defined in TaskMetrics level or NamedCacheMetrics? I think
> the latter makes sense as that holds the cache size at a task level and
> exposes some other cache related metrics as well like hit-ratio.
>
> Thanks!
> Sagar.
>
>
> On Sat, Feb 12, 2022 at 1:14 PM Sagar <sa...@gmail.com> wrote:
>
> > Hi All,
> >
> > There's another amendment proposed for this KIP. We are adding a new
> > metric type called *cache-size-bytes-total *to capture the cache size in
> > bytes accumulated by a task.
> >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
> >
> > Thanks!
> > Sagar.
> >
> > On Mon, Jan 24, 2022 at 7:55 AM Guozhang Wang <wa...@gmail.com>
> wrote:
> >
> >> Thanks Sagar, I'm +1 on the renamed metric.
> >>
> >> On Sat, Jan 22, 2022 at 6:56 PM Sagar <sa...@gmail.com>
> wrote:
> >>
> >> > Hi All,
> >> >
> >> > There is a small update to the KIP whereby the newly introduced metric
> >> > *total-bytes
> >> > *has been renamed to *input-buffer-bytes-total.*
> >> >
> >> > Thanks!
> >> > Sagar.
> >> >
> >> > On Wed, Sep 29, 2021 at 9:57 AM Sagar <sa...@gmail.com>
> >> wrote:
> >> >
> >> > > We have 3 binding votes: Sophie/Guozhang/Mathias
> >> > > and 2 non-binding votes: Josep/Luke and no -1 votes.
> >> > >
> >> > > Marking this KIP as accepted.
> >> > >
> >> > > Thanks everyone!
> >> > >
> >> > > Thanks!
> >> > > Sagar.
> >> > >
> >> > >
> >> > >
> >> > > On Wed, Sep 29, 2021 at 7:18 AM Matthias J. Sax <mj...@apache.org>
> >> > wrote:
> >> > >
> >> > >> +1 (binding)
> >> > >>
> >> > >> On 9/28/21 10:40 AM, Sagar wrote:
> >> > >> > Hi All,
> >> > >> >
> >> > >> > Bumping this vote thread again!
> >> > >> >
> >> > >> > Thanks!
> >> > >> > Sagar.
> >> > >> >
> >> > >> > On Wed, Sep 8, 2021 at 1:19 PM Luke Chen <sh...@gmail.com>
> >> wrote:
> >> > >> >
> >> > >> >> Thanks for the KIP.
> >> > >> >>
> >> > >> >> + 1 (non-binding)
> >> > >> >>
> >> > >> >> Thanks.
> >> > >> >> Luke
> >> > >> >>
> >> > >> >> On Wed, Sep 8, 2021 at 2:48 PM Josep Prat
> >> > <josep.prat@aiven.io.invalid
> >> > >> >
> >> > >> >> wrote:
> >> > >> >>
> >> > >> >>> +1 (non binding).
> >> > >> >>>
> >> > >> >>> Thanks for the KIP Sagar!
> >> > >> >>> ———
> >> > >> >>> Josep Prat
> >> > >> >>>
> >> > >> >>> Aiven Deutschland GmbH
> >> > >> >>>
> >> > >> >>> Immanuelkirchstraße 26, 10405 Berlin
> >> > >> >>>
> >> > >> >>> Amtsgericht Charlottenburg, HRB 209739 B
> >> > >> >>>
> >> > >> >>> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> >> > >> >>>
> >> > >> >>> m: +491715557497
> >> > >> >>>
> >> > >> >>> w: aiven.io
> >> > >> >>>
> >> > >> >>> e: josep.prat@aiven.io
> >> > >> >>>
> >> > >> >>> On Wed, Sep 8, 2021, 03:29 Sophie Blee-Goldman
> >> > >> >> <sophie@confluent.io.invalid
> >> > >> >>>>
> >> > >> >>> wrote:
> >> > >> >>>
> >> > >> >>>> +1 (binding)
> >> > >> >>>>
> >> > >> >>>> Thanks for the KIP!
> >> > >> >>>>
> >> > >> >>>> -Sophie
> >> > >> >>>>
> >> > >> >>>> On Tue, Sep 7, 2021 at 1:59 PM Guozhang Wang <
> >> wangguoz@gmail.com>
> >> > >> >> wrote:
> >> > >> >>>>
> >> > >> >>>>> Thanks Sagar, +1 from me.
> >> > >> >>>>>
> >> > >> >>>>>
> >> > >> >>>>> Guozhang
> >> > >> >>>>>
> >> > >> >>>>> On Sat, Sep 4, 2021 at 10:29 AM Sagar <
> >> sagarmeansocean@gmail.com>
> >> > >> >>> wrote:
> >> > >> >>>>>
> >> > >> >>>>>> Hi All,
> >> > >> >>>>>>
> >> > >> >>>>>> I would like to start a vote on the following KIP:
> >> > >> >>>>>>
> >> > >> >>>>>>
> >> > >> >>>>>
> >> > >> >>>>
> >> > >> >>>
> >> > >> >>
> >> > >>
> >> >
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
> >> > >> >>>>>>
> >> > >> >>>>>> Thanks!
> >> > >> >>>>>> Sagar.
> >> > >> >>>>>>
> >> > >> >>>>>
> >> > >> >>>>>
> >> > >> >>>>> --
> >> > >> >>>>> -- Guozhang
> >> > >> >>>>>
> >> > >> >>>>
> >> > >> >>>
> >> > >> >>
> >> > >> >
> >> > >>
> >> > >
> >> >
> >>
> >>
> >> --
> >> -- Guozhang
> >>
> >
>
--
-- Guozhang
Re: [VOTE] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"
Posted by Sagar <sa...@gmail.com>.
@Guozhang,
I have sent an update to this KIP. I have a question though.. Should this
new metric be defined in TaskMetrics level or NamedCacheMetrics? I think
the latter makes sense as that holds the cache size at a task level and
exposes some other cache related metrics as well like hit-ratio.
Thanks!
Sagar.
On Sat, Feb 12, 2022 at 1:14 PM Sagar <sa...@gmail.com> wrote:
> Hi All,
>
> There's another amendment proposed for this KIP. We are adding a new
> metric type called *cache-size-bytes-total *to capture the cache size in
> bytes accumulated by a task.
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
>
> Thanks!
> Sagar.
>
> On Mon, Jan 24, 2022 at 7:55 AM Guozhang Wang <wa...@gmail.com> wrote:
>
>> Thanks Sagar, I'm +1 on the renamed metric.
>>
>> On Sat, Jan 22, 2022 at 6:56 PM Sagar <sa...@gmail.com> wrote:
>>
>> > Hi All,
>> >
>> > There is a small update to the KIP whereby the newly introduced metric
>> > *total-bytes
>> > *has been renamed to *input-buffer-bytes-total.*
>> >
>> > Thanks!
>> > Sagar.
>> >
>> > On Wed, Sep 29, 2021 at 9:57 AM Sagar <sa...@gmail.com>
>> wrote:
>> >
>> > > We have 3 binding votes: Sophie/Guozhang/Mathias
>> > > and 2 non-binding votes: Josep/Luke and no -1 votes.
>> > >
>> > > Marking this KIP as accepted.
>> > >
>> > > Thanks everyone!
>> > >
>> > > Thanks!
>> > > Sagar.
>> > >
>> > >
>> > >
>> > > On Wed, Sep 29, 2021 at 7:18 AM Matthias J. Sax <mj...@apache.org>
>> > wrote:
>> > >
>> > >> +1 (binding)
>> > >>
>> > >> On 9/28/21 10:40 AM, Sagar wrote:
>> > >> > Hi All,
>> > >> >
>> > >> > Bumping this vote thread again!
>> > >> >
>> > >> > Thanks!
>> > >> > Sagar.
>> > >> >
>> > >> > On Wed, Sep 8, 2021 at 1:19 PM Luke Chen <sh...@gmail.com>
>> wrote:
>> > >> >
>> > >> >> Thanks for the KIP.
>> > >> >>
>> > >> >> + 1 (non-binding)
>> > >> >>
>> > >> >> Thanks.
>> > >> >> Luke
>> > >> >>
>> > >> >> On Wed, Sep 8, 2021 at 2:48 PM Josep Prat
>> > <josep.prat@aiven.io.invalid
>> > >> >
>> > >> >> wrote:
>> > >> >>
>> > >> >>> +1 (non binding).
>> > >> >>>
>> > >> >>> Thanks for the KIP Sagar!
>> > >> >>> ———
>> > >> >>> Josep Prat
>> > >> >>>
>> > >> >>> Aiven Deutschland GmbH
>> > >> >>>
>> > >> >>> Immanuelkirchstraße 26, 10405 Berlin
>> > >> >>>
>> > >> >>> Amtsgericht Charlottenburg, HRB 209739 B
>> > >> >>>
>> > >> >>> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
>> > >> >>>
>> > >> >>> m: +491715557497
>> > >> >>>
>> > >> >>> w: aiven.io
>> > >> >>>
>> > >> >>> e: josep.prat@aiven.io
>> > >> >>>
>> > >> >>> On Wed, Sep 8, 2021, 03:29 Sophie Blee-Goldman
>> > >> >> <sophie@confluent.io.invalid
>> > >> >>>>
>> > >> >>> wrote:
>> > >> >>>
>> > >> >>>> +1 (binding)
>> > >> >>>>
>> > >> >>>> Thanks for the KIP!
>> > >> >>>>
>> > >> >>>> -Sophie
>> > >> >>>>
>> > >> >>>> On Tue, Sep 7, 2021 at 1:59 PM Guozhang Wang <
>> wangguoz@gmail.com>
>> > >> >> wrote:
>> > >> >>>>
>> > >> >>>>> Thanks Sagar, +1 from me.
>> > >> >>>>>
>> > >> >>>>>
>> > >> >>>>> Guozhang
>> > >> >>>>>
>> > >> >>>>> On Sat, Sep 4, 2021 at 10:29 AM Sagar <
>> sagarmeansocean@gmail.com>
>> > >> >>> wrote:
>> > >> >>>>>
>> > >> >>>>>> Hi All,
>> > >> >>>>>>
>> > >> >>>>>> I would like to start a vote on the following KIP:
>> > >> >>>>>>
>> > >> >>>>>>
>> > >> >>>>>
>> > >> >>>>
>> > >> >>>
>> > >> >>
>> > >>
>> >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390
>> > >> >>>>>>
>> > >> >>>>>> Thanks!
>> > >> >>>>>> Sagar.
>> > >> >>>>>>
>> > >> >>>>>
>> > >> >>>>>
>> > >> >>>>> --
>> > >> >>>>> -- Guozhang
>> > >> >>>>>
>> > >> >>>>
>> > >> >>>
>> > >> >>
>> > >> >
>> > >>
>> > >
>> >
>>
>>
>> --
>> -- Guozhang
>>
>