You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/19 01:57:36 UTC

[GitHub] [iceberg] xingfanx commented on a diff in pull request #5304: AWS: handle s3 and glue exceptions more gracefully as user errors

xingfanx commented on code in PR #5304:
URL: https://github.com/apache/iceberg/pull/5304#discussion_r923992414


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -144,6 +146,10 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
           "Cannot commit %s because Glue encountered a validation exception " +
               "while accessing requested resources",
           tableName());
+    } catch (S3Exception e) {
+      throw e;
+    } catch (GlueException e) {
+      throw e;

Review Comment:
   sgtm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org