You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/04/02 02:55:16 UTC

[GitHub] [calcite] danny0405 commented on a change in pull request #2382: [CALCITE-4548] Support convert subQuery for SqlToRelConverter#convertExpression (jibiyr)

danny0405 commented on a change in pull request #2382:
URL: https://github.com/apache/calcite/pull/2382#discussion_r606046774



##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelTestBase.java
##########
@@ -169,6 +170,13 @@ public static void assertValid(RelNode rel) {
      */
     RelRoot convertSqlToRel(String sql);
 
+    /**
+     * Converts a expression string to  {@link RexNode}.
+     *
+     * @param expr expression

Review comment:
       a => an




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org