[jira] [Commented] (MAPREDUCE-4924) flakey test: org.apache.hadoop.mapred.TestClusterMRNotification.testMR

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547435#comment-13547435 ] 

Hadoop QA commented on MAPREDUCE-4924:
--------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12563845/MAPREDUCE-4924.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3213//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3213//console

This message is automatically generated.
                
> flakey test: org.apache.hadoop.mapred.TestClusterMRNotification.testMR
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4924
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4924
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1
>    Affects Versions: 2.0.2-alpha
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Trivial
>         Attachments: MAPREDUCE-4924_branch-1.patch, MAPREDUCE-4924.patch
>
>
> I occasionally get a failure like this on {{org.apache.hadoop.mapred.TestClusterMRNotification.testMR}}
> {code}
> junit.framework.AssertionFailedError: expected:<6> but was:<4>
> 	at junit.framework.Assert.fail(Assert.java:47)
> 	at junit.framework.Assert.failNotEquals(Assert.java:283)
> 	at junit.framework.Assert.assertEquals(Assert.java:64)
> 	at junit.framework.Assert.assertEquals(Assert.java:195)
> 	at junit.framework.Assert.assertEquals(Assert.java:201)
> 	at org.apache.hadoop.mapred.NotificationTestCase.testMR(NotificationTestCase.java:184)
> 	...
> {code}
> It looks like a race condition:
> {code}
>     // run a job with FAILED status
>     System.out.println(UtilsForTests.runJobFail(this.createJobConf(), inDir,
>                                                 outDir).getID());
>     Thread.sleep(2000);
>     assertEquals(6, NotificationServlet.counter);
>     assertEquals(0, NotificationServlet.failureCounter);
> {code}
> Instead of sleeping for 2 seconds, we should keep checking the counter and fail after a timeout.  There's a couple of similar places in the test that should be fixed too.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira