You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2002/12/01 00:24:16 UTC
Re: svn commit: rev 3941 - branches/cvs2svn-mmacek
mmacek@tigris.org wrote:
>Author: mmacek
>Date: 2002-11-30 12:43:24 -0600 (Sat, 30 Nov 2002)
>New Revision: 3941
>
>Modified:
> branches/cvs2svn-mmacek/cvs2svn.py
>Log:
>* cvs2svn.py:
> - parse_revs_line: simplify parsing (use split)
> - Add write_revs_line function for writing the revs data.
> Update two call sites to use it.
>
[snip]
>+ data = line.split(' ', 4)
>+ timestamp = int(data[0], 16)
>+ id = data[1]
>+ op = data[2]
>+ rev = data[3]
>+ fname = data[4][:-1] # strip \n
>
Can you be sure it's a \n, not \r\n? I'd just like to be on the safe side...
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 3941 - branches/cvs2svn-mmacek
Posted by Marko Macek <Ma...@gmx.net>.
Branko Čibej wrote:
>mmacek@tigris.org wrote:
>
>
>>+ data = line.split(' ', 4)
>>+ timestamp = int(data[0], 16)
>>+ id = data[1]
>>+ op = data[2]
>>+ rev = data[3]
>>+ fname = data[4][:-1] # strip \n
>>
>>
>>
>Can you be sure it's a \n, not \r\n? I'd just like to be on the safe side...
>
>
It should be, because FileInput doesn't use 'b' when opening
a file (Support for binary files seems to be on it's TODO list).
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org