You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dg4prez <gi...@git.apache.org> on 2017/05/18 18:16:27 UTC
[GitHub] incubator-trafficcontrol pull request #587: Adds external file download func...
GitHub user dg4prez opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/587
Adds external file download functionality for scripts
This adds simple file download functionality for files not contained within traffic ops, such as lua scripts. These files will be cached using the CDN scope, as they are expected to be static within the update period. Any result other than an http 200 will result in an error return.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dg4prez/incubator-trafficcontrol url_metadata
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/587.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #587
----
commit 19b11fbedc7f14481bec14eccff4f50b91ca26dc
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-05-18T18:13:51Z
Adds external file download functionality for scripts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #587: Adds external file download functionali...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/587
Updated to remove downloading through the traffic ops server and caching, caches download directly from source URL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #587: Adds external file download functionali...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/587
That was my initial design, actually, and it's easier to implement. I suppose my main concern was not pointing a thundering herd at some poor defenseless host that isn't traffic ops. If you guys think that a straight shot from the cache to the hosted file is better I can certainly go that way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #587: Adds external file download functionali...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/587
I'm not really sure how it's dangerous, as in order to use it you have to be an operator or higher.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #587: Adds external file download functionali...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/587
@dg4prez this seems a little dangerous? Not sure why we'd need this functionality when caches by definition can usually go upstream via HTTP to arbitrary endpoints?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #587: Adds external file download func...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/587
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---