You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/05 23:43:20 UTC

[GitHub] [airflow] dstandish commented on pull request #19949: Only update label when adopting to prevent new pods

dstandish commented on pull request #19949:
URL: https://github.com/apache/airflow/pull/19949#issuecomment-1006163853


   > I am not sure if this is the correct change, wdyt @jedcunningham @dstandish
   
   The docstring in the updated method says this
   
   > Patch existing pod so that the current KubernetesJobWatcher can monitor it via label selectors
   
   Looking over the code, it does appear that `airflow-worker` is the only thing that would need to be patched in this scenario.  The other selectors used to find pods (dag id, task id, run  id) would not change in this scenario (scheduler death).
   
   So this looks like it should be  ok  to  me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org