You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/03 19:51:09 UTC

[GitHub] [incubator-superset] nytai commented on a change in pull request #11500: feat: annotation edit modal with antd datepicker

nytai commented on a change in pull request #11500:
URL: https://github.com/apache/incubator-superset/pull/11500#discussion_r516917390



##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -210,7 +210,7 @@ export function useSingleViewResource<D extends object = any>(
             t(
               'An error occurred while fetching %ss: %s',
               resourceLabel,
-              errMsg,
+              JSON.stringify(errMsg),

Review comment:
       This should fix the immediate issue of the error not being displayed, however long term we should probably surface these errors inline in the forms, next to the fields. We could also add validators to the form fields to ensure we're not sending invalid json. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org