You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/03 08:02:20 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31423: [SPARK-34314][SQL] Create new file index after partition schema inferring w/ the schema

HyukjinKwon commented on a change in pull request #31423:
URL: https://github.com/apache/spark/pull/31423#discussion_r569201445



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##########
@@ -413,9 +413,13 @@ case class DataSource(
         } else {
           val globbedPaths = checkAndGlobPathIfNecessary(
             checkEmptyGlobPath = true, checkFilesExist = checkFilesExist)
-          val index = createInMemoryFileIndex(globbedPaths)
+          val fileStatusCache = FileStatusCache.getOrCreate(sparkSession)
+          val indexInSchemaInferring = new InMemoryFileIndex(
+            sparkSession, globbedPaths, options, userSpecifiedSchema, fileStatusCache)

Review comment:
       What's diff from calling `createInMemoryFileIndex` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org