You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by steff1193 <gi...@git.apache.org> on 2017/09/15 13:20:42 UTC

[GitHub] kafka pull request #3872: KAFKA-5716 [WIP]: Recent polled offsets may not be...

GitHub user steff1193 opened a pull request:

    https://github.com/apache/kafka/pull/3872

    KAFKA-5716 [WIP]: Recent polled offsets may not be written/flushed at SourceTask.commit

    @rhauch @tedyu @hachikuji 
    
    For now a test showing that the claimed problem is true. Should definitely not be committed - its a failing test. It fails trying to assert SourceTask.commit javadoc: Commit the offsets, up to the offsets that have been returned by {@link #poll()}
    
    The contribution is my (@steff1193) original work and I license the work to the project under the project's open source license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TeletronicsDotAe/kafka KAFKA-5716

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3872
    
----
commit 9d093478b606f2defdc64ea64e306e46541126e6
Author: Per Steffensen <st...@designware.dk>
Date:   2017-09-15T13:07:04Z

    KAFKA-5716 Added test showing that the claim in KAFKA-5716 is true. It is possible that the offsets of the records from very recent polls are not included in the offsets written and flushed at the time of SourceTask.commit called

----


---