You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/09/30 20:25:23 UTC
[jira] [Commented] (CB-4942) BlackBerry10 never fires deviceready
using cordova-js 3.1.0-rc1
[ https://issues.apache.org/jira/browse/CB-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782074#comment-13782074 ]
ASF subversion and git services commented on CB-4942:
-----------------------------------------------------
Commit 5ad41a7bbd36fdbe948e2310507e7bc52dcefbee in branch refs/heads/master from [~csantana]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=5ad41a7 ]
[CB-4942] [BlackBerry10] deviceready is never fired
- Fix typo event.toLowerCase to type.type.toLowerCase
- Added eventListener for webworksReady to allow nativeReady to fire
Reviewed By: Jeffrey Heifetz <jh...@blackberry.com>
Tested By: Tracy Li <tl...@blackberry.com>
> BlackBerry10 never fires deviceready using cordova-js 3.1.0-rc1
> ---------------------------------------------------------------
>
> Key: CB-4942
> URL: https://issues.apache.org/jira/browse/CB-4942
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry, CordovaJS
> Affects Versions: Master, 3.1.0
> Reporter: Carlos Santana
> Assignee: Carlos Santana
>
> repo cordova-blackberry master#3.1.x has an old cordova.js #3.0.0-0-ge670de9
> The problem is that webworksready never gets register and nativeready fires
> Also a typo on the compare for "webworksready"
> The fix is to update platform.js:
> From
> if (event.toLowerCase() === 'webworksready') {
> needs to be:
> if (type.toLowerCase() === 'webworksready') {
> Then add the listener
> channel.onDOMContentLoaded.subscribe(function () {
> document.addEventListener("webworksready", function () {
> fireWebworksReadyEvent();
> });
> });
> will submit pull request
--
This message was sent by Atlassian JIRA
(v6.1#6144)