You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/15 21:00:05 UTC
[GitHub] [arrow] kszucs opened a new pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
kszucs opened a new pull request #8198:
URL: https://github.com/apache/arrow/pull/8198
I haven't had the time to investigate the build logs, but it will make the build queue pretty slow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-692977688
Also, at the risk of stating the obvious, 6 hours is the wrong order of magnitude for generating documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build on master
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #8198:
URL: https://github.com/apache/arrow/pull/8198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-692994790
According to the crossbow ["logs"](https://github.com/ursa-labs/crossbow/branches/all?query=ubuntu-18.04-docs) the failure started to occur 8 days ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#discussion_r488971793
##########
File path: .github/workflows/dev.yml
##########
@@ -59,42 +59,42 @@ jobs:
continue-on-error: true
run: archery docker push ubuntu-lint
- docs:
- name: Sphinx and API documentations
- runs-on: ubuntu-latest
- if: github.event_name == 'push'
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@v2
- with:
- fetch-depth: 0
- - name: Fetch Submodules and Tags
- shell: bash
- run: ci/scripts/util_checkout.sh
- - name: Free Up Disk Space
- shell: bash
- run: ci/scripts/util_cleanup.sh
- - name: Cache Docker Volumes
- uses: actions/cache@v1
- with:
- path: .docker
- key: ubuntu-18.04-${{ hashFiles('cpp/**') }}
- restore-keys: ubuntu-18.04-
- - name: Setup Python
- uses: actions/setup-python@v1
- with:
- python-version: 3.8
- - name: Setup Archery
- run: pip install -e dev/archery[docker]
- - name: Execute Docker Build
- run: |
- sudo sysctl -w kernel.core_pattern="core.%e.%p"
- ulimit -c unlimited
- archery docker run ubuntu-docs
- - name: Docker Push
- if: success() && github.event_name == 'push' && github.repository == 'apache/arrow'
- continue-on-error: true
- run: archery docker push ubuntu-docs
+ # docs:
Review comment:
Why not just delete it? All of the useful logic is in the `ubuntu-docs` docker-compose job, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-692978930
https://issues.apache.org/jira/browse/ARROW-10018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-693015027
It's not timing out on the nightly azure job, FWIW
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#discussion_r488984588
##########
File path: .github/workflows/dev.yml
##########
@@ -59,42 +59,42 @@ jobs:
continue-on-error: true
run: archery docker push ubuntu-lint
- docs:
- name: Sphinx and API documentations
- runs-on: ubuntu-latest
- if: github.event_name == 'push'
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@v2
- with:
- fetch-depth: 0
- - name: Fetch Submodules and Tags
- shell: bash
- run: ci/scripts/util_checkout.sh
- - name: Free Up Disk Space
- shell: bash
- run: ci/scripts/util_cleanup.sh
- - name: Cache Docker Volumes
- uses: actions/cache@v1
- with:
- path: .docker
- key: ubuntu-18.04-${{ hashFiles('cpp/**') }}
- restore-keys: ubuntu-18.04-
- - name: Setup Python
- uses: actions/setup-python@v1
- with:
- python-version: 3.8
- - name: Setup Archery
- run: pip install -e dev/archery[docker]
- - name: Execute Docker Build
- run: |
- sudo sysctl -w kernel.core_pattern="core.%e.%p"
- ulimit -c unlimited
- archery docker run ubuntu-docs
- - name: Docker Push
- if: success() && github.event_name == 'push' && github.repository == 'apache/arrow'
- continue-on-error: true
- run: archery docker push ubuntu-docs
+ # docs:
Review comment:
I'm fine with dropping it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build on master
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-693019521
> It's not timing out on the nightly azure job, FWIW
The [last one](https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=17388&view=results) took 6 hours.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-692998263
Looking at the first crossbow failure, there's an R `pkgdown` dependency that's failing to install (but not failing the build), so the R doc building fails later.
Adding `apt-get install libfontconfig1-dev` may solve this, though I'll look into other ways to speed R dependency installation up.
That seems separate from this though; could you make a JIRA for the failing job please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-692982196
> Don't we run this nightly on crossbow too?
We do, and it seems like the build timeouts there as well so we must have a bug laying around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-693014886
The timeout failure is pretty recent so we have multiple issues here. I'm going to create the tickets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#issuecomment-692977399
Don't we run this nightly on crossbow too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#discussion_r488983097
##########
File path: .github/workflows/dev.yml
##########
@@ -59,42 +59,42 @@ jobs:
continue-on-error: true
run: archery docker push ubuntu-lint
- docs:
- name: Sphinx and API documentations
- runs-on: ubuntu-latest
- if: github.event_name == 'push'
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@v2
- with:
- fetch-depth: 0
- - name: Fetch Submodules and Tags
- shell: bash
- run: ci/scripts/util_checkout.sh
- - name: Free Up Disk Space
- shell: bash
- run: ci/scripts/util_cleanup.sh
- - name: Cache Docker Volumes
- uses: actions/cache@v1
- with:
- path: .docker
- key: ubuntu-18.04-${{ hashFiles('cpp/**') }}
- restore-keys: ubuntu-18.04-
- - name: Setup Python
- uses: actions/setup-python@v1
- with:
- python-version: 3.8
- - name: Setup Archery
- run: pip install -e dev/archery[docker]
- - name: Execute Docker Build
- run: |
- sudo sysctl -w kernel.core_pattern="core.%e.%p"
- ulimit -c unlimited
- archery docker run ubuntu-docs
- - name: Docker Push
- if: success() && github.event_name == 'push' && github.repository == 'apache/arrow'
- continue-on-error: true
- run: archery docker push ubuntu-docs
+ # docs:
Review comment:
Specifically, I meant why not delete rather than comment out.
Regardless of bugs/performance, it doesn't make sense to me to run a heavy job on every commit and also nightly. That's redundant. Nightly seems sufficient to me, but regardless we should drop one or the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8198: ARROW-10018: [CI] Disable Sphinx and API documentation build since it takes 6 hours on master
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#discussion_r488975449
##########
File path: .github/workflows/dev.yml
##########
@@ -59,42 +59,42 @@ jobs:
continue-on-error: true
run: archery docker push ubuntu-lint
- docs:
- name: Sphinx and API documentations
- runs-on: ubuntu-latest
- if: github.event_name == 'push'
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@v2
- with:
- fetch-depth: 0
- - name: Fetch Submodules and Tags
- shell: bash
- run: ci/scripts/util_checkout.sh
- - name: Free Up Disk Space
- shell: bash
- run: ci/scripts/util_cleanup.sh
- - name: Cache Docker Volumes
- uses: actions/cache@v1
- with:
- path: .docker
- key: ubuntu-18.04-${{ hashFiles('cpp/**') }}
- restore-keys: ubuntu-18.04-
- - name: Setup Python
- uses: actions/setup-python@v1
- with:
- python-version: 3.8
- - name: Setup Archery
- run: pip install -e dev/archery[docker]
- - name: Execute Docker Build
- run: |
- sudo sysctl -w kernel.core_pattern="core.%e.%p"
- ulimit -c unlimited
- archery docker run ubuntu-docs
- - name: Docker Push
- if: success() && github.event_name == 'push' && github.repository == 'apache/arrow'
- continue-on-error: true
- run: archery docker push ubuntu-docs
+ # docs:
Review comment:
Do you mean that we should rely on the nightly crossbow job instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org