You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/03/30 19:40:28 UTC
[PR] [SPARK-56293] Make `BaseAppDriverObserver` abstract class `sealed` [spark-kubernetes-operator]
dongjoon-hyun opened a new pull request, #607:
URL: https://github.com/apache/spark-kubernetes-operator/pull/607
### What changes were proposed in this pull request?
This PR makes `BaseAppDriverObserver` a `sealed` class with `permits AppDriverReadyObserver, AppDriverRunningObserver, AppDriverStartObserver, AppDriverTimeoutObserver`. All four subclasses are marked `final`.
### Why are the changes needed?
Using a `sealed` class explicitly restricts the permitted implementations, improving type safety and enabling exhaustive pattern matching in `switch` expressions with Java 21.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs with the existing tests.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56293] Make `BaseAppDriverObserver` abstract class `sealed` [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #607:
URL: https://github.com/apache/spark-kubernetes-operator/pull/607#issuecomment-4157758372
Thank you so much, @viirya ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56293] Make `BaseAppDriverObserver` abstract class `sealed` [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #607: [SPARK-56293] Make `BaseAppDriverObserver` abstract class `sealed`
URL: https://github.com/apache/spark-kubernetes-operator/pull/607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56293] Make `BaseAppDriverObserver` abstract class `sealed` [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #607:
URL: https://github.com/apache/spark-kubernetes-operator/pull/607#issuecomment-4157765056
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org