[I] fix(build): Astryx surface inventory cannot see most of the design system [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han opened a new issue, #3868:
URL: https://github.com/apache/maka/issues/3868

   ## Problem
   
   #3064 made the inventory check symmetric and #3646 kept it globally enforced. Both fixed the plumbing — whether the two halves agree and whether the gate runs. This is the third gap in the same file, and it is semantic: **what the gate is able to detect at all.**
   
   The severity model only recognizes raw interactive primitives:
   
   ```js
   if (rawButton || rawInput || rawSelect) severity = 'blocker';
   else if (rawTextarea) severity = 'polish';
   ```
   
   **1. A hand-rolled replacement for a shipped Astryx component scores `aligned`.** It renders no raw control, so it is indistinguishable from a genuinely aligned file — and the inventory then certifies it. A surface added this way reads `| … | none | aligned — no raw controls; no Astryx JSX usage | aligned |`, moving the totals from `aligned 212` to `aligned 213`. The rule as stated in `docs/astryx-alignment-inventory.md:36` is "Raw `<button>` / `<input>` / `<select>` with Astryx twin" — it covers wrong primitive, not redundant component.
   
   **2. `ASTRYX_COMPONENTS` is a hand-maintained second representation of what Astryx ships.** It holds 47 names; `@astryxdesign/core/dist` has 107 component directories. `Timestamp` is absent, so it appears **0 times** across all 214 rows even though `packages/ui/src/chat-turn.tsx` imports and renders it. `ChatMessage`, `ChatMessageMetadata`, and `Thumbnail` are invisible the same way — so removing an Astryx component from a file leaves its row byte-identical, which is how this surfaced.
   
   ## Desired outcome
   
   - Derive the known-component set from `@astryxdesign/core` instead of maintaining a second list, so the "Astryx used" column is a true record and design-system additions are picked up without a manual edit. This is the same root cause #3064 identified — a generated artifact whose input is hand-maintained drifts in whichever half the author forgets.
   - Add a severity tier for "re-implements a component Astryx already provides", so swapping an Astryx component for a local equivalent is visible in review.
   
   Found while reviewing #3681.
   
   *AI use: analysis performed with Claude Code and verified against the repository.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [I] fix(build): Astryx surface inventory cannot see most of the design system [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han closed issue #3868: fix(build): Astryx surface inventory cannot see most of the design system
URL: https://github.com/apache/maka/issues/3868


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org