You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-commits@incubator.apache.org by th...@apache.org on 2010/12/26 19:37:53 UTC

svn commit: r1052927 - in /incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay: GaussianRandomDelayTimer.java RandomDelayTimer.java SimpleDelayTimer.java

Author: thorsten
Date: Sun Dec 26 19:37:53 2010
New Revision: 1052927

URL: http://svn.apache.org/viewvc?rev=1052927&view=rev
Log:
DROIDS-101
GaussianRandomDelayTimer misspell
Reporter: 	Alexander Zazhigin
Patch: Bertil Chapuis

Modified:
    incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/GaussianRandomDelayTimer.java
    incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/RandomDelayTimer.java
    incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/SimpleDelayTimer.java

Modified: incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/GaussianRandomDelayTimer.java
URL: http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/GaussianRandomDelayTimer.java?rev=1052927&r1=1052926&r2=1052927&view=diff
==============================================================================
--- incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/GaussianRandomDelayTimer.java (original)
+++ incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/GaussianRandomDelayTimer.java Sun Dec 26 19:37:53 2010
@@ -18,24 +18,41 @@ package org.apache.droids.delay;
 
 import org.apache.droids.api.DelayTimer;
 
-public class GaussianRandomDelayTimer extends RandomDelayTimer implements DelayTimer 
+/**
+ * An instance of this class is used to generate Gaussian distributed
+ * random delays.
+ */
+public class GaussianRandomDelayTimer extends RandomDelayTimer implements DelayTimer
 {
+
+  /**
+   * Creates a new Gaussian distributed random delay generator
+   */
   public GaussianRandomDelayTimer()
   {
-    super( 0, 0 );
+    super(0, 0);
   }
 
-  public GaussianRandomDelayTimer( int min, int range )
+  /**
+   * Creates a new Gaussian distributed delay generator with minimum and 
+   * range constraints.
+   * 
+   * @param min
+   * @param range
+   */
+  public GaussianRandomDelayTimer(int min, int range)
   {
-    super( min, range );
+    super(min, range);
   }
 
-  public long getDelayMillis() 
+  @Override
+  public long getDelayMillis()
   {
     double delay;
     do {
-      delay = ( random.nextGaussian() + 1 ) / 2;
+      delay = (random.nextGaussian() + 1) / 2;
     } while (delay < 0 || delay > 1);
-    return (long) delay * delaySpread + minimumDelay;
+    return (long) (delay * delaySpread + minimumDelay);
   }
+  
 }

Modified: incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/RandomDelayTimer.java
URL: http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/RandomDelayTimer.java?rev=1052927&r1=1052926&r2=1052927&view=diff
==============================================================================
--- incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/RandomDelayTimer.java (original)
+++ incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/RandomDelayTimer.java Sun Dec 26 19:37:53 2010
@@ -20,44 +20,84 @@ import java.util.Random;
 
 import org.apache.droids.api.DelayTimer;
 
-public class RandomDelayTimer implements DelayTimer 
+/**
+ * An instance of this class is used to generate random delays.
+ */
+public class RandomDelayTimer implements DelayTimer
 {
+
   protected final Random random;
   protected int minimumDelay;
   protected int delaySpread;
-  
+
+  /**
+   * Creates a new random delay generator,
+   */
   public RandomDelayTimer()
   {
-    this( 0, 0 );
+    this(0, 0);
   }
 
-  public RandomDelayTimer( int min, int range )
+  /**
+   * Creates a new random delay generator with minimum and range constraints.
+   *
+   * @param min
+   * @param range
+   */
+  public RandomDelayTimer(int min, int range)
   {
     random = new Random();
     minimumDelay = min;
     delaySpread = range;
   }
-  
-  public long getDelayMillis() {
-    if( delaySpread > 0 ) {
-      return (long) this.random.nextInt( delaySpread ) + minimumDelay;
+
+  @Override
+  public long getDelayMillis()
+  {
+    if (delaySpread > 0) {
+      return (long) this.random.nextInt(delaySpread) + minimumDelay;
     }
     return 0;
   }
 
-  public int getMinimumDelay() {
+  /**
+   * Returns the minimum delay
+   *
+   * @return the minimum delay
+   */
+  public int getMinimumDelay()
+  {
     return minimumDelay;
   }
 
-  public void setMinimumDelay(int minimumDelay) {
+  /**
+   * Sets the minimum delay
+   *
+   * @param minimumDelay
+   */
+  public void setMinimumDelay(int minimumDelay)
+  {
     this.minimumDelay = minimumDelay;
   }
 
-  public int getDelaySpread() {
+  /**
+   * Returns the delay spread
+   *
+   * @return the delay spread
+   */
+  public int getDelaySpread()
+  {
     return delaySpread;
   }
 
-  public void setDelaySpread(int delayRange) {
-    this.delaySpread = delayRange;
+  /**
+   * Sets the delay spread
+   *
+   * @param delaySpread
+   */
+  public void setDelaySpread(int delaySpread)
+  {
+    this.delaySpread = delaySpread;
   }
+
 }

Modified: incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/SimpleDelayTimer.java
URL: http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/SimpleDelayTimer.java?rev=1052927&r1=1052926&r2=1052927&view=diff
==============================================================================
--- incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/SimpleDelayTimer.java (original)
+++ incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/delay/SimpleDelayTimer.java Sun Dec 26 19:37:53 2010
@@ -18,27 +18,35 @@ package org.apache.droids.delay;
 
 import org.apache.droids.api.DelayTimer;
 
-public class SimpleDelayTimer implements DelayTimer 
+/**
+ * An instance of this class is used to generate fixed delays.
+ */
+public class SimpleDelayTimer implements DelayTimer
 {
   /**
    * The fixed value of the delay.
    */
   private long delayMillis = 0;
   
+  /**
+   * Creates a new fixed delay generator.
+   */
   public SimpleDelayTimer()
   {
     
   }
   
+  /**
+   * Creates a new fixed delay generator.
+   *
+   * @param delay
+   */
   public SimpleDelayTimer( long delay )
   {
     this.delayMillis = delay;
   }
 
-  /**
-   * Gets the delay time.
-   * @param delay long
-   */
+  @Override
   public long getDelayMillis() {
     return this.delayMillis;
   }
@@ -50,4 +58,5 @@ public class SimpleDelayTimer implements
   public void setDelayMillis(long delay) {
     this.delayMillis = delay;
   }
+  
 }